From: Kalle Valo <kvalo@codeaurora.org>
To: Cody Schuffelen <schuffelen@google.com>
Cc: joelaf@google.com, sergey.matyukevich.os@quantenna.com,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device
Date: Sat, 06 Oct 2018 15:01:44 +0300 [thread overview]
Message-ID: <87tvlzffmf.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAAELVAGAZ-UM77P=JqzHjUGja9oJcN5y9+YvxZWKBmOXAu=zNQ@mail.gmail.com> (Cody Schuffelen's message of "Fri, 5 Oct 2018 14:59:27 -0700")
Cody Schuffelen <schuffelen@google.com> writes:
> Thanks for the comments! I will work on incorporating the suggested
> changes.
Few important remarks:
1. Do not EVER submit HTML mails, mailing lists will automatically
reject them. So your mail didn't reach the lists and I only got it
because I was in the Cc field.
2. Do not top post, it's really annoying:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#do_not_top_post_and_edit_your_quotes
3. Reply to the review comments you get, even if you agree with them. By
not replying you give an impression that you are ignoring the review
comments.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-06 12:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 19:59 [PATCH net-next v3] wireless-drivers: rtnetlink wifi simulation device Cody Schuffelen
2018-10-05 14:33 ` Sergey Matyukevich
2018-10-05 21:05 ` Joel Fernandes
2018-10-05 21:08 ` Joel Fernandes
[not found] ` <CAAELVAGAZ-UM77P=JqzHjUGja9oJcN5y9+YvxZWKBmOXAu=zNQ@mail.gmail.com>
2018-10-06 12:01 ` Kalle Valo [this message]
2018-11-21 3:20 ` Cody Schuffelen
2018-10-08 13:56 ` Sergey Matyukevich
2018-11-21 3:20 ` Cody Schuffelen
2018-10-06 11:52 ` Kalle Valo
2018-11-21 3:20 ` Cody Schuffelen
2018-10-09 8:25 ` Johannes Berg
2018-11-21 3:20 ` Cody Schuffelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvlzffmf.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=joelaf@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schuffelen@google.com \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).