From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbdFEQTR (ORCPT ); Mon, 5 Jun 2017 12:19:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44754 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbdFEQTN (ORCPT ); Mon, 5 Jun 2017 12:19:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 76BC43B716 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vkuznets@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 76BC43B716 From: Vitaly Kuznetsov To: Steven Rostedt Cc: devel@linuxdriverproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jork Loeser , Simon Xiao , Andy Lutomirski Subject: Re: [PATCH v4 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others() References: <20170524120405.19079-1-vkuznets@redhat.com> <20170524120405.19079-11-vkuznets@redhat.com> <20170605115048.472b5cfa@gandalf.local.home> Date: Mon, 05 Jun 2017 18:19:08 +0200 In-Reply-To: <20170605115048.472b5cfa@gandalf.local.home> (Steven Rostedt's message of "Mon, 5 Jun 2017 11:50:48 -0400") Message-ID: <87tw3u76gz.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 05 Jun 2017 16:19:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt writes: > On Wed, 24 May 2017 14:04:05 +0200 > Vitaly Kuznetsov wrote: > >> Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). >> Tracing is done the same way we do xen_mmu_flush_tlb_others(). >> >> Signed-off-by: Vitaly Kuznetsov >> Acked-by: K. Y. Srinivasan >> Tested-by: Simon Xiao >> Tested-by: Srikanth Myakam >> --- >> MAINTAINERS | 1 + >> arch/x86/hyperv/mmu.c | 8 ++++++++ >> arch/x86/include/asm/trace/hyperv.h | 34 ++++++++++++++++++++++++++++++++++ >> 3 files changed, 43 insertions(+) >> create mode 100644 arch/x86/include/asm/trace/hyperv.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 9e98464..045e10a 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6168,6 +6168,7 @@ M: Stephen Hemminger >> L: devel@linuxdriverproject.org >> S: Maintained >> F: arch/x86/include/asm/mshyperv.h >> +F: arch/x86/include/asm/trace/hyperv.h >> F: arch/x86/include/uapi/asm/hyperv.h >> F: arch/x86/kernel/cpu/mshyperv.c >> F: arch/x86/hyperv >> diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c >> index c9cecb3..f6b5211 100644 >> --- a/arch/x86/hyperv/mmu.c >> +++ b/arch/x86/hyperv/mmu.c >> @@ -6,6 +6,10 @@ >> #include >> #include >> #include >> +#include >> + >> +#define CREATE_TRACE_POINTS >> +DEFINE_TRACE(hyperv_mmu_flush_tlb_others); > > The above looks very wrong. Why are you using "DEFINE_TRACE()" here? > > The typical case is: > > #define CREATE_TRACE_POINTS > #include > I probably got the idea wrong from Documentation/trace/tracepoints.txt: "In subsys/file.c (where the tracing statement must be added) : #include #define CREATE_TRACE_POINTS DEFINE_TRACE(subsys_eventname); void somefct(void) { ... trace_subsys_eventname(arg, task); ... } " > Does your patch even work? > I'm pretty sure I tested tracing this even before sending v2 of this series, I'll retest before sending v7. > -- Steve > >> >> /* HvFlushVirtualAddressSpace, HvFlushVirtualAddressList hypercalls */ >> struct hv_flush_pcpu { >> @@ -75,6 +79,8 @@ static void hyperv_flush_tlb_others(const struct cpumask *cpus, >> u64 status = -1ULL; >> int cpu, vcpu, gva_n, max_gvas; >> >> + trace_hyperv_mmu_flush_tlb_others(cpus, mm, start, end); >> + >> if (!pcpu_flush || !hv_hypercall_pg) >> goto do_native; >> >> @@ -161,6 +167,8 @@ static void hyperv_flush_tlb_others_ex(const struct cpumask *cpus, >> u64 status = -1ULL; >> int nr_bank = 0, max_gvas, gva_n; >> >> + trace_hyperv_mmu_flush_tlb_others(cpus, mm, start, end); >> + >> if (!pcpu_flush_ex || !hv_hypercall_pg) >> goto do_native; >> >> diff --git a/arch/x86/include/asm/trace/hyperv.h b/arch/x86/include/asm/trace/hyperv.h >> new file mode 100644 >> index 0000000..e46a351 >> --- /dev/null >> +++ b/arch/x86/include/asm/trace/hyperv.h >> @@ -0,0 +1,34 @@ >> +#undef TRACE_SYSTEM >> +#define TRACE_SYSTEM hyperv >> + >> +#if !defined(_TRACE_HYPERV_H) || defined(TRACE_HEADER_MULTI_READ) >> +#define _TRACE_HYPERV_H >> + >> +#include >> + >> +#if IS_ENABLED(CONFIG_HYPERV) >> + >> +TRACE_EVENT(hyperv_mmu_flush_tlb_others, >> + TP_PROTO(const struct cpumask *cpus, struct mm_struct *mm, >> + unsigned long addr, unsigned long end), >> + TP_ARGS(cpus, mm, addr, end), >> + TP_STRUCT__entry( >> + __field(unsigned int, ncpus) >> + __field(struct mm_struct *, mm) >> + __field(unsigned long, addr) >> + __field(unsigned long, end) >> + ), >> + TP_fast_assign(__entry->ncpus = cpumask_weight(cpus); >> + __entry->mm = mm; >> + __entry->addr = addr, >> + __entry->end = end), >> + TP_printk("ncpus %d mm %p addr %lx, end %lx", >> + __entry->ncpus, __entry->mm, __entry->addr, __entry->end) >> + ); >> + >> +#endif /* CONFIG_HYPERV */ >> + >> +#endif /* _TRACE_HYPERV_H */ >> + >> +/* This part must be outside protection */ >> +#include -- Vitaly