From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbcKGD5F (ORCPT ); Sun, 6 Nov 2016 22:57:05 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:45489 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752082AbcKGD5D (ORCPT ); Sun, 6 Nov 2016 22:57:03 -0500 X-IronPort-AV: E=Sophos;i="5.31,604,1473087600"; d="scan'";a="225246361" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <87twbk9cg8.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Russell King - ARM Linux CC: Archit Taneja , Mark Brown , David Airlie , Fabio Estevam , Daniel Vetter , Koji Matsuoka , Thierry Reding , Linux-ALSA , Liam Girdwood , Simon , , , , Jose Abreu Subject: Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support In-Reply-To: <20161102082758.GV1041@n2100.armlinux.org.uk> References: <871syu4r3x.wl%kuninori.morimoto.gx@renesas.com> <20161102082758.GV1041@n2100.armlinux.org.uk> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Mon, 7 Nov 2016 03:50:00 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: OSXPR01CA0003.jpnprd01.prod.outlook.com (10.167.143.140) To SG2PR0601MB1453.apcprd06.prod.outlook.com (10.169.106.19) X-MS-Office365-Filtering-Correlation-Id: bd22c149-905a-4dcc-5564-08d406c12721 X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;2:XIeVupU0jPBBhcuBy/qFzF+NLnj/hc8vvAIVktfPcuYkzLCKVbDHcpXDuD5R/sd+AQhMFTk7PWLBVCujExt5XYNxZIuIQ6MEAM8idavxXs05w3r3tChUHvBeJZhLKD+6Pg92bJ07Murp38DzjDjVRGtEYHIuegok7muTXmWWYtIfztd0hSd71BPAZW7Lx7rXB33aRUDPlnqno91Wl0Q/ZA==;3:dKFwVDD3/01W/qQ+ApY4iGSkNJQIkjXvJsvoD8nsaKTInQlVrc0G9qUqi9kd4lX4WhVwyEyFb4irdfUVyEt8Gl/VcaBj6/8+rB+QaJ0e+ZnisQSHvyarRNpiPMEB3xdQJcgBOqBRBBb3eqimQUl2sg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR0601MB1453; X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;25:ShuRQKrrXS90s2o6YudFlPwZWGF4CJmsqEsZFgrOxu01CdoJgfczbA+ZWhAeeniIbz37nRKx1LnpEiidaPa8OJ4wVq1m4oAGHbatyMOoDBRCE+6tQEpH9YBZU+aeV0YMrWqMpHbKTKPTouNAmwgFA4muE9IakpYvHFEALxye8s0qkvIZy1Nnf9Thq+Bi7oapDpfcNRPV71F8cvjERdl6gKISDPJNmbKWJAC28gqQ3vTne+4vFxZ4p5EK3nsnZlJXHTspAYa6NB/dxx0y+YoZa/F7DzFzOBt8m7UkGIlMd8yLbeGC0nOxlIY5n/18LUyPCvfaO3PdAdZMBiYQuZuzLdUJ3R1Ni7WngXLXDaIGru4p8MS8jSmw1F8AnOzNTqFoUwV7qWwLwZYX9KDkvIJGTUE0+i+2OqU0mflE5jKh8NewBoZ5+qP9mLQ/JrdTCTHrlXGy+T+Xn4a80bhuyfRoNeiEZpHq8Gx1JGSOSGTJCPIqQO9X29HIUZ1aKkG5wvPopbu7EL2b/W7VB4er4kyFz3r4LoitYq+59/Fzc6qhXvPLy5UD9d6B1Gn2LMQHrhejsrFOE6FUkjx9t4cYPe96OPrEwvpdBWG+lGMkT7m20FuH2IHJk2LQSLmNxHPfCOKl2vJ3amtDCrs0og4x0nWLpJaNQnd5CIQwVok4Mool2ZnV/i55Dcjg8ogOKvHVetdV/t8B2ByYaXUWGG7AhF+eSvoJD72vk++J1294Dh8n+DI= X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;31:WtT8PxTB4yaCj41skssTy42Dm1oBBIAezNRpA8OfTb3HQ7Gaxooi4BeNwe5WSkTQjfNNXYAuaphZ1eb3ZNOlYyH7hC9tnrtI80GaE2+o43iXGWlrwjL9WkLqVbOo2urN2+31OdgdQuuhaYOzkAv6Ro5xe+4nboqJgdFIqu7lMH9iK89N0FkMcILgl2ZuTLbXjmZtIzCGETR1LVPSMtrhQtOIs7KfRQSHy2Js9FmTRh3g1BbYtv92+7ZSOg1vqpDGOO7S/+imkKArxX8XsaQLjQ==;20:5kuuGVwqvCb4c83W3oyT/10JBppA3WeoDPIYeEnwVSDGI3CtKUjCWRqMk4atc7RkuSTcRLEc5oMBUwtiQzDbuTUsjmx6j7inv2NmUo0XDrCtvP+mD2b4iqnVyCIoPvZJ35oBJ0uznuoS/bTEd/lUofvVMILADUh9cDRegaG6/PDz5ahQ0VRBkUPYf/wcdCw3juUS93ZuZuwxcWpNQ1+zhS455gcg6mhISFhWCyklZHvzuxl4pmpkV6SOJAk49tGrA54IPbBAY6yv/Es8XiQa2JaUW4m5/ltimSDJ1nOn/fe7qLPkI3uRv6xrecsHrajj/ES7GGMWrCrjd3jJyVXw9jvNNsc6Wn2fXX0A0mL8f95oEbQ03ruedjZfdiocSexbg1/g7o1vvKcJpPejzX3lVeZuBdrxiyOt+tywa0AxnfzNkCsOGJLm0zmA3E/Q0xyYUsPQ3+dpX8xywAB+jJuh8wKc8EPIGQNGaM/270NL3mdEQJcfd/0AN7EscftYwkuR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:SG2PR0601MB1453;BCL:0;PCL:0;RULEID:;SRVR:SG2PR0601MB1453; X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;4:qGxFZaIlclFS5NuEmfDAdieoOpmfhZEXJE9fPFCmqixFdIlyUP1tf7IWeOOTCeUZRVIB5PNp0KqGjM41IxQHh1VAm3Xve3O1P7Ic1mqvAFXPN6ohjRExq5ccH9EG7/tfH7MjVPg+f4K0ivdOzogaUaSnP9gDsaMN7bfqg4X0HLS61BdVTIFEFJw8vdcC9LgwSul0GYzbshBDlCTNHNNrlPRzBeD1MRfmKtCl9N3JwCSq7Zeq2ETAsgWBAt1OHo2puGIH1Js8Fn2Us6FuMrF9Y1Dl1q8LhiZGc0Bj8JAer4VK34pUDW/9CDVZlzqz6kPVza/0O+tYN1xRt3ZRrEkpoiL32esa2Kext6Y2w25mg3DGniEGZNKEkAOlDcfqh1VK9vRRsaemdiAUE1omvHABrQfDObYLMvUBu6nUMyGM17Q= X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(7736002)(7846002)(4001350100001)(47776003)(77096005)(66066001)(3846002)(6116002)(23726003)(8666005)(305945005)(586003)(4326007)(69596002)(81156014)(46406003)(83506001)(81166006)(2906002)(53416004)(42186005)(6916009)(86362001)(68736007)(50986999)(8676002)(50466002)(110136003)(101416001)(2950100002)(105586002)(92566002)(189998001)(106356001)(7416002)(345774005)(54356999)(76176999)(5660300001)(36756003)(33646002)(97736004)(7059030)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR0601MB1453;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SG2PR0601MB1453;23:vsLFoC8vC+CyMCjQN0Jd2yFwob/HOJCyTzxSzs4?= =?us-ascii?Q?EeAEfps8TJDKXZcaKTcKX4/fJy8SKGSJY0kv1PIFqx+DV2Geu5rXnuaqCuA1?= =?us-ascii?Q?CdC9tiiSxx/DmSN7QnM+jwMnprAospxrEw5m3JfGh4ysbOibrR+WDA8YOK0K?= =?us-ascii?Q?fiPyb/h9tgG1rQlNNtyVNPBe4MYaoAB8RshwUsDh37sfsHHqLkSNGdTs47Sm?= =?us-ascii?Q?pug3qPSXHaS69+zWlxZ2KXpcuq85ln5P5Q899SfwV0tp1SXmlIENoZ0ZhlgX?= =?us-ascii?Q?3sY9xLx0ahwrbf0/PRJm0fyWx+L3cw3kUlwTSeb1DoPvC3meTh63vTkF7cxd?= =?us-ascii?Q?F+DyI55nDF3hfLqafRYhJ50D61RVvLWkjsbqIIvMMDmSeI3d2yDjZTg+RFjY?= =?us-ascii?Q?9XCPt0+WTqos+KITLVj6ollhv+2aDEgXwf005LvSz7WJHNwFjkvBBVhhCZHh?= =?us-ascii?Q?/02jUJxvRBzWr+mJlgeiLkTogOBb6lKUQG6V1vCqRSVp3iKR3EkhzEprkuJy?= =?us-ascii?Q?lu5Ui2G3rscwm2BBeeQbZq7DnrcT92lZw7oe4AbOZxmZ5qDgsaLO8HQHz4c/?= =?us-ascii?Q?mXLbCvcbi+BmAa6cNN2D9lVXnNqi8mIAnu3dSPI9GhFeTCbV7rrlXWBfqU7B?= =?us-ascii?Q?+P57FSOvo/tZN7M4NsCK31g9l1Lzty7pt5CDEUNnWLU5vCQF1TTQnGR8naL9?= =?us-ascii?Q?Ki2CnlXKVDVlrvyA8JcuEirmdQdAggvMa3jyseOxUDWOfg0H1tz/dAc0xq9F?= =?us-ascii?Q?f6oPd6WsB2oIA8iPyCuX09eBpqMoWHV+iR/CAKAhtGUEZsUiUYEjpWY93Soi?= =?us-ascii?Q?VoXVbvdFM0AEPVJcXd5qYKdYVHTInMyffdDTb91TbTJ4cvACFWWhi6wIMaR+?= =?us-ascii?Q?wy7oJyGpFcbjsG4dLHEg7+G0rhM7Bf2jIlMp6BbEnU346nCnHtRatPYTs83T?= =?us-ascii?Q?LgMT0qeDfSeHUjjE5cY2o6SRR7YUU5jvaZzKNXKGtoT79CBb5fZnZUaWmaZC?= =?us-ascii?Q?yKZmiAI5NhAnev2C34FxNIQNinUv/KmeVUbfTiOWU106pNU8f+d2qvpjQ2xQ?= =?us-ascii?Q?BCFEjvFHs09mqHBpf5fT2WKXaW61h31bGr8B75o/gN6+sCw98ktjzgQhuFNT?= =?us-ascii?Q?xP5RmRAHxLym9S7jRcrn/TepOsZ37W0Ef4N9d7vPbTjf4ru/dMDrQqTt8Opg?= =?us-ascii?Q?X8JocALGYZHgEH4axlSrnMyzzCzN/nPTLupmV?= X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;6:lCMqpBlbe9fMdoam99oMcq80QozhAh/cuTisOeDGfG9+Y4qZiXDFUYMXclK1XbTx2qKDuYlPf0J7NKCjvh1bSEH2CchARTM42bIDaC86fGYJmD9vOgmUyTT1oShv9aYC+X+skkWvPi6PCvtCB0AurxdK3f9uN3x9YDmCKeCUdzyaa+bnvcr094BIUgunwKZmAadBmp5cr9dHi1xoD4DRcJY7bni1eRpsZVEu5Mue/3f0IZdclO0yCuRCYaTo4ZfHYCQaUiB0du0llW53zJKRiWrTiOAR7ByFEu0rksbM2YuMWGOa9dZj4Jc8Fye4hfFJgxssrKd6HpXlXMFLPMERlzc3VIL3rp4iGTd9mFwFJVg=;5:L9XZs80OovEfU40lFKJZYtCIQt9zqUCTD1FsD8RuHyqcLl1unEz7NMNZeh8Bk0HF5+z0LeV/GsOqoCPoTnPfRb3X07VIXoWgsfQCgy2NsWvdFocjpisWnn09m9qNAaunRdF6BIsT0YsGALo+cyRB6wbccwIQy9jCYHnvWI3M5Ug=;24:PBxo2n3vPhlLbcYwcliZm8NAwDuSxm7lr8nqMfbO0y15eIFNwRdABeZjHYutNHpa/UyDvMrrVzy3yQt0Fr20VmeO9aNz06WskWTcUaAXlIY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SG2PR0601MB1453;7:8VTet7ioWme1Cd2Zd6HHQrXPmM4SbYYyE9TMQE/vFRg8e+e/T6N8uFETyxGagTUHrZECK4B9fLw4yb6j1CXeY4tyVj+rAH683F4xAq4J9Kvm1HL8r1r1+6o5I3wRQwezYmaMUsNkmYuoyzQpeOy+6FVgDdj09OZ+DqjvBD7dVXUBsEx02wh4zvMm/Psngo3rHzLAEXijv2fcDXRxJHeqN1Y4k2PmPyxIunWAUe91QBU+qsIVEkjpSp24VAKF3u88qu4wpBf2hL8LITahrbHEpb4Z3WeY1Cjy9Yjy2cOws7+lnL9dMM9YJNCOOMYaPAq3vJZztzJUG44NFN4xoNQybkQzKeGF87yNINbsoUyJsAk=;20:uTBnxtoHZeHvpADEX8vssWJNlNE/yvnhCX0UgOjyaCKHuFwhUzWS7CtlJgTq+OVBxbdArmnxRQnTSyGLVsVBVwLduIZHIs9nmiU+grlvrg7I3W9ZarQ8WP2OdRnjcjcf+ycDB6ecioqI1GOy3bNIqhvHUK/D2EnEHe4JshH8GPE= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 03:50:00.5610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1453 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell > > + platform = platform_device_register_full(&pdevinfo); > > + if (IS_ERR_OR_NULL(platform)) > > + return PTR_ERR(platform); > > This is wrong. If platform is NULL, PTR_ERR() will return zero, which > will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(), > it leads to exactly this kind of cockup - and it's unnecessary here > because platform_device_register_full() does not return NULL. Thank you for your feedback. Before sending v4 patch, I would like to confirm. Do you meand this ? # use IS_ERR() instead of IS_ERR_OR_NULL() platform = platform_device_register_full(&pdevinfo); if (IS_ERR(platform)) return PTR_ERR(platform);