From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932289AbbETUyn (ORCPT ); Wed, 20 May 2015 16:54:43 -0400 Received: from ozlabs.org ([103.22.144.67]:45885 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515AbbETUyg (ORCPT ); Wed, 20 May 2015 16:54:36 -0400 From: Rusty Russell To: Michal Marek , Joe Perches , One Thousand Gnomes Cc: David Woodhouse , LKML , Quentin Casasnovas , Andreas Schwab Subject: Re: mod_devicetable: Make dmi_strmatch.substr const char * In-Reply-To: <555C36D1.4060003@suse.cz> References: <1431994055.2870.102.camel@perches.com> <1432018018.3277.22.camel@infradead.org> <20150519165630.169c64d3@lxorguk.ukuu.org.uk> <1432063162.2870.199.camel@perches.com> <878ucjhlmg.fsf@rustcorp.com.au> <555C36D1.4060003@suse.cz> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 21 May 2015 06:01:03 +0930 Message-ID: <87twv7c7p4.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Marek writes: > Dne 20.5.2015 v 13:19 Rusty Russell napsal(a): >> Joe Perches writes: >>> On Tue, 2015-05-19 at 16:56 +0100, One Thousand Gnomes wrote: >>>> On Tue, 19 May 2015 07:46:58 +0100 David Woodhouse wrote: >>>>> On Mon, 2015-05-18 at 17:07 -0700, Joe Perches wrote: >>>>>> changed dmi_strmatch.substr from char * to char[79]; >>>>>> >>>>>> Changing it back to const char * would shrink an x86-64 >>>>>> defconfig more than 100KB. > > As David already pointed out, this breaks modpost. Also, what makes > the dmi tables special? We use character arrays in other tables as > well, to make them self-contained for modpost. Yes, but the patch I referred to merely shrunk it, or changed it to a pointer in the !CONFIG_MODULES case. modpost has gotten far more sophisticated, thanks mainly to the init section detection code. So it now knows about relocations; it would be possible to use the same infrastructure to decode char *, and I think it might be worth it. It'd be a nice trick if someone were to code it :) >> But it seems the file2alias code was rewritten in 2013 by Andreas Schwab >> , and SOB Michal Marek , without >> going through me. Annoying, since they had to hack it because people >> screwed up mod_devicetable.h with arch-dependent layouts :( > > Oh, sorry about it. > >> I guess that means Michal is the maintainer now, so I've CC'd him. > > OK, fine, I can carry modpost patches in kbuid.git. I think I have > merged a few more besides the file2alias rework. Sure, let's do that from now on; I was a bit surprised but I'm always happy for others to do my work for me :) Thanks, Rusty.