From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933788AbbCDMGf (ORCPT ); Wed, 4 Mar 2015 07:06:35 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:14104 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933197AbbCDMGc (ORCPT ); Wed, 4 Mar 2015 07:06:32 -0500 X-IronPort-AV: E=McAfee;i="5600,1067,7729"; a="198303324" X-IronPort-AV: E=Sophos;i="5.09,687,1418112000"; d="scan'208";a="853510810" From: Kalle Valo To: SF Markus Elfring CC: , , , Julia Lawall , , LKML Subject: Re: [PATCH] ath10k: Delete unnecessary checks before the function call "release_firmware" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54D26614.2080708@users.sourceforge.net> Date: Wed, 4 Mar 2015 14:06:21 +0200 In-Reply-To: <54D26614.2080708@users.sourceforge.net> (SF Markus Elfring's message of "Wed, 04 Feb 2015 19:33:56 +0100") Message-ID: <87twy16k76.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01E.na.qualcomm.com (10.85.0.31) To NASANEXM01G.na.qualcomm.com (10.85.0.33) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SF Markus Elfring writes: > From: Markus Elfring > Date: Wed, 4 Feb 2015 19:30:23 +0100 > > The release_firmware() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks, applied to ath.git. -- Kalle Valo