From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F3BC388F7 for ; Sun, 25 Oct 2020 11:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20BE4222E8 for ; Sun, 25 Oct 2020 11:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603626693; bh=Y628XiExNaybMG+0qV8apMIusz2ZNiURDLMRnRSO5+c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=GrCgJzTYZ5S5QZGsPRaSh5YnOvHqmnl7KHcHpPDT9+VRYdNu82yd+eDM2nt097IVu Xpsd2oStKv4gsyTYBcBenWPLwqzLLNbsyjFaXZtvUGGswee2tqGVy93uWCwht7AVQZ OpzbcS9waWXFSWpwLjNgTnlk293w5S4RMI1FkFlg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1415512AbgJYLvb (ORCPT ); Sun, 25 Oct 2020 07:51:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731893AbgJYLvb (ORCPT ); Sun, 25 Oct 2020 07:51:31 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 543A921D41; Sun, 25 Oct 2020 11:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603626690; bh=Y628XiExNaybMG+0qV8apMIusz2ZNiURDLMRnRSO5+c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LCotHgYNOGdwEW7O1OTxPplr9j4so/P+W4GnAHt5S9Yc4dYp1Kfr255/nx49/AUr6 wtpESBjytvFvLBXkeQ/ru/e82+wqXlaenGwOx/0k9l9TVDbTLYJYknYe3LFG0UWDw4 lKsnw+QlhjJMSXoSZjaxrC8OYnm3A1ZLzCcfZogg= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWeYa-0043Dq-GQ; Sun, 25 Oct 2020 11:51:28 +0000 Date: Sun, 25 Oct 2020 11:51:27 +0000 Message-ID: <87v9eyo75s.wl-maz@kernel.org> From: Marc Zyngier To: Neil Armstrong Cc: jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, khilman@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module In-Reply-To: <20201020072532.949137-1-narmstrong@baylibre.com> References: <20201020072532.949137-1-narmstrong@baylibre.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: narmstrong@baylibre.com, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, khilman@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2020 08:25:30 +0100, Neil Armstrong wrote: > > In order to reduce the kernel Image size on multi-platform distributions, > make it possible to build the Amlogic GPIO IRQ controller as a module > by switching it to a platform driver. > > The second patch removes MESON_IRQ_GPIO selection from ARCH_MESON to allow > building the driver as module. > > Neil Armstrong (2): > irqchip: irq-meson-gpio: make it possible to build as a module > arm64: meson: remove MESON_IRQ_GPIO selection > > arch/arm64/Kconfig.platforms | 1 - > drivers/irqchip/Kconfig | 5 +- > drivers/irqchip/irq-meson-gpio.c | 89 ++++++++++++++++++++------------ > 3 files changed, 59 insertions(+), 36 deletions(-) I've tried this series on my vim3l with the this driver compiled as a module, and lost the Ethernet interface in the process, as the phy wasn't able to resolve its interrupt and things fail later on: [ 72.238291] meson8b-dwmac ff3f0000.ethernet eth1: no phy at addr -1 [ 72.238917] meson8b-dwmac ff3f0000.ethernet eth1: stmmac_open: Cannot attach to PHY (error: -19) This is a generic problem with making DT-based interrupt controllers modular when not *all* the drivers can deal with probing deferral. M. -- Without deviation from the norm, progress is not possible.