From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAFEC433DF for ; Mon, 8 Jun 2020 11:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C5832074B for ; Mon, 8 Jun 2020 11:38:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GShdFatV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729612AbgFHLiz (ORCPT ); Mon, 8 Jun 2020 07:38:55 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:38245 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729565AbgFHLiy (ORCPT ); Mon, 8 Jun 2020 07:38:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591616334; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=UlNfDGogKCJ2Hte3WfYZUyoDNhoWUwvyIBaQzivZeyg=; b=GShdFatVvOWxN9ghijzuG2F35IZdwRzFCBvvYxP+Qou4rfnZiMzo9YzNjEaGtzJ1Mr9OYF/V CkzWTslPS3TFZ7t81rIHO+/srROHy82vPXHnXF6/7VZazmFcyxHpBP2g9rL0u2QngCnedxJ8 myGn19Olt3hIY0UdCCSBTcZHADI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n12.prod.us-east-1.postgun.com with SMTP id 5ede234a8bec5077688023cc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Jun 2020 11:38:50 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B8DF7C433A1; Mon, 8 Jun 2020 11:38:48 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 920A6C433CA; Mon, 8 Jun 2020 11:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 920A6C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Evan Green Cc: Govind Singh , kuabhs@google.com.org, sujitka@chromium.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Michal Kazior , Jakub Kicinski , "David S. Miller" Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths References: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> Date: Mon, 08 Jun 2020 14:38:43 +0300 In-Reply-To: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> (Evan Green's message of "Thu, 4 Jun 2020 10:59:11 -0700") Message-ID: <87v9k1iy7w.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Evan Green writes: > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > is held. Acquire the lock in a couple of error paths when calling that > function to ensure this condition is met. > > Fixes: 6421969f248fd ("ath10k: refactor tx pending management") > Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64 > descriptor") Fixes tag should be in one line, I fixed that in the pending branch. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches