From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46379C433E0 for ; Fri, 22 May 2020 19:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07930206D5 for ; Fri, 22 May 2020 19:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730959AbgEVTe5 (ORCPT ); Fri, 22 May 2020 15:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730866AbgEVTe5 (ORCPT ); Fri, 22 May 2020 15:34:57 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6C30C061A0E for ; Fri, 22 May 2020 12:34:56 -0700 (PDT) Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jcDQw-0003eL-4L; Fri, 22 May 2020 21:34:18 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 7C99C100F17; Fri, 22 May 2020 21:34:17 +0200 (CEST) From: Thomas Gleixner To: LKML Cc: Andy Lutomirski , Andrew Cooper , X86 ML , "Paul E. McKenney" , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon , Tom Lendacky , Wei Liu , Michael Kelley , Jason Chen CJ , Zhao Yakui , "Peter Zijlstra \(Intel\)" Subject: Re: [patch V9 21/39] x86/irq: Convey vector as argument and not in ptregs In-Reply-To: <20200521202118.796915981@linutronix.de> References: <20200521200513.656533920@linutronix.de> <20200521202118.796915981@linutronix.de> Date: Fri, 22 May 2020 21:34:17 +0200 Message-ID: <87v9knrcg6.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner writes: > + .align 8 > +SYM_CODE_START(irq_entries_start) > + vector=FIRST_EXTERNAL_VECTOR > + pos = . > + .rept (FIRST_SYSTEM_VECTOR - FIRST_EXTERNAL_VECTOR) > + UNWIND_HINT_IRET_REGS > + .byte 0x6a, vector > + jmp common_interrupt > + .nops (pos + 8) - . Boris pointed out that .nops requires binutils >=2.31 ... Sigh! The below delta patch works for the purpose. Thanks, tglx --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -475,7 +475,9 @@ SYM_CODE_START(irq_entries_start) UNWIND_HINT_IRET_REGS .byte 0x6a, vector jmp asm_common_interrupt - .nops (pos + 8) - . + nop + /* Ensure that the above is 8 bytes max */ + . = pos + 8 pos=pos+8 vector=vector+1 .endr @@ -490,7 +492,9 @@ SYM_CODE_START(spurious_entries_start) UNWIND_HINT_IRET_REGS .byte 0x6a, vector jmp asm_spurious_interrupt - .nops (pos + 8) - . + nop + /* Ensure that the above is 8 bytes max */ + . = pos + 8 pos=pos+8 vector=vector+1 .endr