From: Michael Ellerman <mpe@ellerman.id.au>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Christopher Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
Gautham R Shenoy <ego@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus
Date: Mon, 11 May 2020 21:27:07 +1000 [thread overview]
Message-ID: <87v9l2btkk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200508132130.GC1961@linux.vnet.ibm.com>
Srikar Dronamraju <srikar@linux.vnet.ibm.com> writes:
> * Christopher Lameter <cl@linux.com> [2020-05-02 22:55:16]:
>
>> On Fri, 1 May 2020, Srikar Dronamraju wrote:
>>
>> > - for_each_present_cpu(cpu)
>> > - numa_setup_cpu(cpu);
>> > + for_each_possible_cpu(cpu) {
>> > + /*
>> > + * Powerpc with CONFIG_NUMA always used to have a node 0,
>> > + * even if it was memoryless or cpuless. For all cpus that
>> > + * are possible but not present, cpu_to_node() would point
>> > + * to node 0. To remove a cpuless, memoryless dummy node,
>> > + * powerpc need to make sure all possible but not present
>> > + * cpu_to_node are set to a proper node.
>> > + */
>> > + if (cpu_present(cpu))
>> > + numa_setup_cpu(cpu);
>> > + else
>> > + set_cpu_numa_node(cpu, first_online_node);
>> > + }
>> > }
>>
>> Can this be folded into numa_setup_cpu?
>>
>> This looks more like numa_setup_cpu needs to change?
>
> We can fold this into numa_setup_cpu().
>
> However till now we were sure that numa_setup_cpu() would be called only for
> a present cpu. That assumption will change.
> + (non-consequential) an additional check everytime cpu is hotplugged in.
>
> If Michael Ellerman is okay with the change, I can fold it in.
Yes I agree it would be better in numa_setup_cpu().
cheers
next prev parent reply other threads:[~2020-05-11 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 3:11 [PATCH v3 0/3] Offline memoryless cpuless node 0 Srikar Dronamraju
2020-05-01 3:11 ` [PATCH v3 1/3] powerpc/numa: Set numa_node for all possible cpus Srikar Dronamraju
2020-05-02 22:55 ` Christopher Lameter
2020-05-08 13:21 ` Srikar Dronamraju
2020-05-11 11:27 ` Michael Ellerman [this message]
2020-05-01 3:11 ` [PATCH v3 2/3] powerpc/numa: Prefer node id queried from vphn Srikar Dronamraju
2020-05-01 3:11 ` [PATCH v3 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline Srikar Dronamraju
2020-05-02 23:05 ` Christopher Lameter
2020-05-08 13:05 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9l2btkk.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=ego@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).