From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>,
Chin-Yen Lee <timlee@realtek.com>,
"David S. Miller" <davem@davemloft.net>,
Brian Norris <briannorris@chromium.org>,
Chris Chiu <chiu@endlessm.com>,
Jian-Hong Pan <jian-hong@endlessm.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtw88: avoid unused function warnings
Date: Thu, 09 Apr 2020 07:29:39 +0300 [thread overview]
Message-ID: <87v9m9uvrg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200408185413.218643-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 8 Apr 2020 20:53:51 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> The rtw88 driver defines emtpy functions with multiple indirections
> but gets one of these wrong:
>
> drivers/net/wireless/realtek/rtw88/pci.c:1347:12: error: 'rtw_pci_resume' defined but not used [-Werror=unused-function]
> 1347 | static int rtw_pci_resume(struct device *dev)
> | ^~~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/pci.c:1342:12: error: 'rtw_pci_suspend' defined but not used [-Werror=unused-function]
> 1342 | static int rtw_pci_suspend(struct device *dev)
>
> Better simplify it to rely on the conditional reference in
> SIMPLE_DEV_PM_OPS(), and mark the functions as __maybe_unused to avoid
> warning about it.
>
> I'm not sure if these are needed at all given that the functions
> don't do anything, but they were only recently added.
>
> Fixes: 44bc17f7f5b3 ("rtw88: support wowlan feature for 8822c")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'll queue this to v5.7.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-09 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 18:53 [PATCH] rtw88: avoid unused function warnings Arnd Bergmann
2020-04-09 4:29 ` Kalle Valo [this message]
2020-04-14 12:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9m9uvrg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=briannorris@chromium.org \
--cc=chiu@endlessm.com \
--cc=davem@davemloft.net \
--cc=jian-hong@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timlee@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).