From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2420C34021 for ; Mon, 17 Feb 2020 15:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96E7620718 for ; Mon, 17 Feb 2020 15:35:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uz9oWtwL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728902AbgBQPfM (ORCPT ); Mon, 17 Feb 2020 10:35:12 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50623 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728823AbgBQPfL (ORCPT ); Mon, 17 Feb 2020 10:35:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581953710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I94s+/OW2nmFtGVziJ+53lmgRDQEQNRHpvcvNRvPjFg=; b=Uz9oWtwLYuCDLZQ6pGFOwN47vY9HVwUFSrs6OYzi17EliHIAvWEJWBDXU1KnnqjO1Qgo8T xrYTr6NuHPWYBLmDFbiTNRdofkeKrdz5UTRmOqt1AeUJToSUKMZX/PXsQPC5dX8XgqEG6Y mQ3yUoLOOyZgdugMWOqPRGFoIGSfsRg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-2LVmJ5_mPwuzffNM1gSIfQ-1; Mon, 17 Feb 2020 10:35:08 -0500 X-MC-Unique: 2LVmJ5_mPwuzffNM1gSIfQ-1 Received: by mail-wr1-f71.google.com with SMTP id w6so9118474wrm.16 for ; Mon, 17 Feb 2020 07:35:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=I94s+/OW2nmFtGVziJ+53lmgRDQEQNRHpvcvNRvPjFg=; b=CgN4OHPVrgMHrg3vpV7YUUhghaQwGtJ9/ou/3ZRTz6mpmLTsqq5VY9M3Gxffhu8QxS 4+bCGj4qf6nBgIk6U9aJ0LvbddqVxBPwBXs3gFQlLiGB/1sxkp2n7l96++8x0azUGYN8 7hPdL9e0YkYa3f4aPHcGTzG76FpnXScop39JCFqq8PZDEPvUQEeCq5NoMblSwEFIoLRI aAiyd9Fs0MaEISJhWDuL6Nv8nheFcr1zJz+IqrsWaNjhP+dE27mjR137bY2gCKAhMsxF yWwVnSbpmNJAipcDhKq5nkXPz4lUbXm5LN/Rv2h2IMFIPI0Q1lcSTK5RzezxbPrL9Jt6 tjlw== X-Gm-Message-State: APjAAAUqVRbYpECfGBRpv+kOmnza6waajkVrXIHjoKzKOniTGi7wghiF 6rjgox+FidCXtS/yTs7qeOgLm60SiZLPKaEyNiGZM9nfN24IMSIxpWMqJXwLQvlRWuPRKOId0e7 /5VFoUQiDliDlLiCgsT3oFOlO X-Received: by 2002:a7b:cd8e:: with SMTP id y14mr22883682wmj.150.1581953707732; Mon, 17 Feb 2020 07:35:07 -0800 (PST) X-Google-Smtp-Source: APXvYqw70CrrrSfMwVWl7qnn5bAkrGx2tWvnt4qyiyI0/zrMUKDzlnUG9J1tN9btzikV0/JwRnl8xw== X-Received: by 2002:a7b:cd8e:: with SMTP id y14mr22883657wmj.150.1581953707447; Mon, 17 Feb 2020 07:35:07 -0800 (PST) Received: from vitty.brq.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id y8sm1018221wma.10.2020.02.17.07.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 07:35:06 -0800 (PST) From: Vitaly Kuznetsov To: Sean Christopherson , Peter Xu Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 15/19] KVM: Provide common implementation for generic dirty log functions In-Reply-To: <20200207194532.GK2401@linux.intel.com> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-16-sean.j.christopherson@intel.com> <20200206200200.GC700495@xz-x1> <20200206212120.GF13067@linux.intel.com> <20200206214106.GG700495@xz-x1> <20200207194532.GK2401@linux.intel.com> Date: Mon, 17 Feb 2020 16:35:05 +0100 Message-ID: <87v9o59qhi.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sean Christopherson writes: > +Vitaly for HyperV > > On Thu, Feb 06, 2020 at 04:41:06PM -0500, Peter Xu wrote: >> On Thu, Feb 06, 2020 at 01:21:20PM -0800, Sean Christopherson wrote: >> > On Thu, Feb 06, 2020 at 03:02:00PM -0500, Peter Xu wrote: >> > > But that matters to this patch because if MIPS can use >> > > kvm_flush_remote_tlbs(), then we probably don't need this >> > > arch-specific hook any more and we can directly call >> > > kvm_flush_remote_tlbs() after sync dirty log when flush==true. >> > >> > Ya, the asid_flush_mask in kvm_vz_flush_shadow_all() is the only thing >> > that prevents calling kvm_flush_remote_tlbs() directly, but I have no >> > clue as to the important of that code. >> >> As said above I think the x86 lockdep is really not necessary, then >> considering MIPS could be the only one that will use the new hook >> introduced in this patch... Shall we figure that out first? > > So I prepped a follow-up patch to make kvm_arch_dirty_log_tlb_flush() a > MIPS-only hook and use kvm_flush_remote_tlbs() directly for arm and x86, > but then I realized x86 *has* a hook to do a precise remote TLB flush. > There's even an existing kvm_flush_remote_tlbs_with_address() call on a > memslot, i.e. this exact scenario. So arguably, x86 should be using the > more precise flush and should keep kvm_arch_dirty_log_tlb_flush(). > > But, the hook is only used when KVM is running as an L1 on top of HyperV, > and I assume dirty logging isn't used much, if at all, for L1 KVM on > HyperV? (Sorry for the delayed reply, was traveling last week) When KVM runs as an L1 on top of Hyper-V it uses eVMCS by default and eVMCSv1 doesn't support PML. I've also just checked Hyper-V 2019 and it hides SECONDARY_EXEC_ENABLE_PML from guests (this was expected). > > I see three options: > > 1. Make kvm_arch_dirty_log_tlb_flush() MIPS-only and call > kvm_flush_remote_tlbs() directly for arm and x86. Add comments to > explain when an arch should implement kvm_arch_dirty_log_tlb_flush(). > > 2. Change x86 to use kvm_flush_remote_tlbs_with_address() when flushing > a memslot after the dirty log is grabbed by userspace. > > 3. Keep the resulting code as is, but add a comment in x86's > kvm_arch_dirty_log_tlb_flush() to explain why it uses > kvm_flush_remote_tlbs() instead of the with_address() variant. > > I strongly prefer to (2) or (3), but I'll defer to Vitaly as to which of > those is preferable. I'd vote for (2): while this will effectively be kvm_flush_remote_tlbs() for now, we may think of something smarter in the future (e.g. PV interface for KVM-on-KVM). > > I don't like (1) because (a) it requires more lines code (well comments), > to explain why kvm_flush_remote_tlbs() is the default, and (b) it would > require even more comments, which would be x86-specific in generic KVM, > to explain why x86 doesn't use its with_address() flush, or we'd lost that > info altogether. > -- Vitaly