From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()
Date: Tue, 01 Aug 2017 05:54:09 +0900 [thread overview]
Message-ID: <87vam8tjim.fsf@devron> (raw)
In-Reply-To: <CAHp75Vd1gTFuw+ubDpe94uiooakNVHUf0cHDtsoop8dhOBKo9w@mail.gmail.com> (Andy Shevchenko's message of "Mon, 31 Jul 2017 22:31:29 +0300")
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>> +
>> + *(wchar_t *)op = uc[0] << 8 | uc[1];
>> +
>> + op += 2;
>
> This had been in the original patch 6 years ago and had been refused
> because of endianess issues.
Sorry, I forgot what I said completely. Maybe I changed my mind?
if (uni_xlate == 1) {
*op++ = ':';
op = hex_byte_pack(op, ec >> 8);
op = hex_byte_pack(op, ec);
len -= 5;
Here is output. So "uc[0] << 8 | uc[1]" is right code, isn't it?
>> charlen = nls->char2uni(ip, len - i,
>> - (wchar_t *)op);
>> + (wchar_t *)op);
>
> It perfectly fits one line.
It over 80 column.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2017-07-31 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 14:33 [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko
2017-07-31 18:40 ` OGAWA Hirofumi
2017-07-31 18:44 ` OGAWA Hirofumi
2017-07-31 19:31 ` Andy Shevchenko
2017-07-31 20:54 ` OGAWA Hirofumi [this message]
2017-08-01 12:56 ` Andy Shevchenko
2017-07-31 19:39 ` Andy Shevchenko
2017-07-31 20:56 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vam8tjim.fsf@devron \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).