From: NeilBrown <neilb@suse.com>
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
robh@kernel.org, Jun Li <jun.li@nxp.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Peter Chen <peter.chen@freescale.com>,
Alan Stern <stern@rowland.harvard.edu>,
grygorii.strashko@ti.com,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Linux PM list <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
device-mainlining@lists.linuxfoundation.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation
Date: Wed, 09 Nov 2016 07:38:36 +1100 [thread overview]
Message-ID: <87vavxn1v7.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20161108084133.GA12276@b29397-desktop>
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
On Tue, Nov 08 2016, Peter Chen wrote:
> On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote:
>>
>>
>>
>> 2/ Change all usb phys to register an extcon and to send appropriate
>> notifications. Many already do, but I don't think it is universal.
>> It is probable that the extcon should be registered using common code
>> instead of each phy driver having its own
>> extcon_get_edev_by_phandle()
>> or whatever.
>> If the usb phy driver needs to look at battery charger registers to
>> know what sort of cable was connected (which I believe is the case
>> for the chips you are interested in), then it should do that.
>
> Not only USB PHY to register an extcon, but also for the drivers which
> can detect USB charger type, it may be USB controller driver, USB type-c
> driver, pmic driver, and these drivers may not have an extcon device
> since the internal part can finish the vbus detect.
Can you point to an example of the sort of hardware/driver you are
referring to, preferably in the mainline kernel. Concrete examples make
this sort of thing much easier to understand.
I think I would argue that if some piece of hardware can detect the USB
charger type, then that piece of hardware is part of the "USB PHY", even
if the hardware manufacturer has chosen to partition the register set in
a way which doesn't make that obvious.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-11-08 20:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 2:37 [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-10-19 2:37 ` [PATCH v18 1/4] usb: gadget: Introduce the usb charger framework Baolin Wang
2016-10-19 2:37 ` [PATCH v18 2/4] usb: gadget: Support for " Baolin Wang
2016-10-19 2:37 ` [PATCH v18 3/4] usb: gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang
2016-10-19 2:37 ` [PATCH v18 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang
2016-10-27 7:33 ` [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-10-27 22:00 ` NeilBrown
2016-10-28 12:51 ` Baolin Wang
2016-10-28 17:03 ` Mark Brown
2016-10-31 11:25 ` Baolin Wang
2016-10-31 0:00 ` NeilBrown
2016-11-01 12:54 ` Baolin Wang
2016-11-03 1:25 ` NeilBrown
2016-11-07 8:14 ` Baolin Wang
2016-11-07 20:36 ` NeilBrown
2016-11-10 9:42 ` Baolin Wang
2016-11-14 4:21 ` NeilBrown
2016-11-14 12:04 ` Mark Brown
2016-11-14 21:35 ` NeilBrown
2016-11-15 5:03 ` Peter Chen
2016-11-16 16:16 ` Mark Brown
2016-11-17 6:46 ` NeilBrown
2016-11-21 17:17 ` Mark Brown
2016-11-21 22:40 ` NeilBrown
2016-11-25 13:00 ` Mark Brown
2016-11-26 0:44 ` NeilBrown
2016-11-28 7:15 ` Baolin Wang
2016-11-14 12:36 ` Baolin Wang
2016-11-08 8:41 ` Peter Chen
2016-11-08 20:38 ` NeilBrown [this message]
2016-11-09 1:33 ` Peter Chen
2016-12-20 7:05 ` Baolin Wang
2016-12-20 22:07 ` NeilBrown
2016-12-21 2:54 ` Baolin Wang
2016-12-21 3:48 ` NeilBrown
2016-12-21 9:07 ` Baolin Wang
2016-12-21 23:47 ` NeilBrown
2016-12-22 7:06 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vavxn1v7.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=balbi@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=device-mainlining@lists.linuxfoundation.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hzpeterchen@gmail.com \
--cc=john.stultz@linaro.org \
--cc=jun.li@nxp.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.chen@freescale.com \
--cc=robh@kernel.org \
--cc=ruslan.bilovol@gmail.com \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).