From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764290AbcJaJuU (ORCPT ); Mon, 31 Oct 2016 05:50:20 -0400 Received: from ozlabs.org ([103.22.144.67]:43359 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754376AbcJaJuS (ORCPT ); Mon, 31 Oct 2016 05:50:18 -0400 From: Michael Ellerman To: Andrew Donnellan , Christophe JAILLET , imunsie@au1.ibm.com, fbarrat@linux.vnet.ibm.com Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxl: Fix error handling In-Reply-To: References: <20161030213451.24624-1-christophe.jaillet@wanadoo.fr> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Oct 2016 20:50:12 +1100 Message-ID: <87vaw826gb.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Donnellan writes: > On 31/10/16 08:34, Christophe JAILLET wrote: >> 'cxl_dev_context_init()' returns an error pointer in case of error, not >> NULL. So test it with IS_ERR. >> >> Signed-off-by: Christophe JAILLET > > Reviewed-by: Andrew Donnellan > >> --- >> un-compiled because I don't have the required cross build environment. > > Builds fine here. > > In future, you might want to bundle all 3 of your patches either into 1 > patch (while they are changes which can be done separately, it's all > fixes to one type of problem in relation to one function, so personally > I'm okay with that) or send it as a series, so that it's clear to > everyone that they're all related fixes. > Additionally, having the same patch subject line for two patches sent in > short succession is a bit confusing - in future, try and avoid that. Yeah. I actually assumed it was two versions of the same patch. cheers