From: Kalle Valo <kvalo@codeaurora.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org,
ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@linaro.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] fix:gpio: mark symbols static where possible
Date: Mon, 29 Aug 2016 15:14:05 +0300 [thread overview]
Message-ID: <87vayj3h82.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1472315228-14802-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Sun, 28 Aug 2016 00:27:08 +0800")
Baoyou Xie <baoyou.xie@linaro.org> writes:
> We get 1 warning about global functions without a declaration
> in the ath9k gpio driver when building with W=1:
> drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/net/wireless/ath/ath9k/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The commit title should be:
ath9k: mark ath_fill_led_pin() static
Check the wiki how to create titles:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name
--
Kalle Valo
prev parent reply other threads:[~2016-08-29 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 16:27 [PATCH] fix:gpio: mark symbols static where possible Baoyou Xie
2016-08-29 12:14 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vayj3h82.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=arnd@linaro.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=baoyou.xie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).