From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756263AbcFGWQa (ORCPT ); Tue, 7 Jun 2016 18:16:30 -0400 Received: from anholt.net ([50.246.234.109]:52206 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323AbcFGWQ3 (ORCPT ); Tue, 7 Jun 2016 18:16:29 -0400 From: Eric Anholt To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: Gerd Hoffmann , linux-rpi-kernel@lists.infradead.org, Will Deacon , open list , Catalin Marinas Subject: Re: [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig. In-Reply-To: <3299125.qWct7BqQgQ@wuerfel> References: <1464934708-24769-1-git-send-email-kraxel@redhat.com> <1464934708-24769-6-git-send-email-kraxel@redhat.com> <3299125.qWct7BqQgQ@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Jun 2016 15:16:24 -0700 Message-ID: <87vb1k4pc7.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > On Friday, June 3, 2016 8:18:24 AM CEST Gerd Hoffmann wrote: >> From: Eric Anholt >>=20 >> Made with make defconfig; make menuconfig (only saying Y to new >> entries); make savedefconfig. > > Please try not to mix 'make savedefconfig' changes with your > own changes, it make it harder to review and can lead to more > conflicts. > >> @@ -140,6 +141,9 @@ CONFIG_USB_NET_PLUSB=3Dm >> CONFIG_USB_NET_MCS7830=3Dm >> CONFIG_WL18XX=3Dm >> CONFIG_WLCORE_SDIO=3Dm >> +CONFIG_USB_USBNET=3Dy >> +CONFIG_USB_NET_SMSC95XX=3Dy >> +# CONFIG_WLAN is not set >> CONFIG_INPUT_EVDEV=3Dy >> CONFIG_KEYBOARD_GPIO=3Dy > > Can this be =3Dm like the others? I guess, but it's an on-board device and I was assuming =3Dm was about whether the device is always present on the board being added. >> -CONFIG_FB=3Dy >> -CONFIG_FRAMEBUFFER_CONSOLE=3Dy > > Is this intended? > >> +CONFIG_DRM=3Dy >> +CONFIG_DRM_VC4=3Dy >> CONFIG_FB_ARMCLCD=3Dy >> CONFIG_LOGO=3Dy > > Maybe modules? It looks like in multi_v7_defconfig we have CONFIG_DRM=3Dy but CONFIG_DRM_*=3Dm, so should we be consistent with that? >> # CONFIG_LOGO_LINUX_MONO is not set >> # CONFIG_LOGO_LINUX_VGA16 is not set >> CONFIG_SOUND=3Dy >> CONFIG_SND=3Dy >> CONFIG_SND_SOC=3Dy >> +CONFIG_SND_BCM2835_SOC_I2S=3Dy >> CONFIG_SND_SOC_RCAR=3Dy >> CONFIG_SND_SOC_AK4613=3Dy >> CONFIG_USB=3Dy > > We probably want CONFIG_SND=3Dm, but that should be a separate patch. > >> @@ -270,6 +284,7 @@ CONFIG_RTC_DRV_SUN6I=3Dy >> CONFIG_RTC_DRV_XGENE=3Dy >> CONFIG_DMADEVICES=3Dy >> CONFIG_PL330_DMA=3Dy >> +CONFIG_DMA_BCM2835=3Dy >> CONFIG_TEGRA20_APB_DMA=3Dy >> CONFIG_QCOM_BAM_DMA=3Dy >> CONFIG_RCAR_DMAC=3Dy > > Does any essential driver depend on this one? bcm2835-sdhost and vc4 will eventually. >> @@ -311,7 +329,6 @@ CONFIG_AUTOFS4_FS=3Dy >> CONFIG_FUSE_FS=3Dy >> CONFIG_CUSE=3Dy >> CONFIG_VFAT_FS=3Dy >> -CONFIG_TMPFS=3Dy >> CONFIG_HUGETLBFS=3Dy >> CONFIG_CONFIGFS_FS=3Dy >> CONFIG_EFIVAR_FS=3Dy > > Why? DRM was selecting it, so savedefconfig dropped it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXV0e5AAoJELXWKTbR/J7oQZgQAIW8cLkqGS0kbPnSeEpxPYua EvVEEM4Ut/Sr58jdv5wb4HCRG6XlSXSWH5/mlDqecwJKzt9N+700feHwX+7uYyrf lEKlc0DURz9B3HU3OY++ZKIe3N/kIj9p7jEnHXzwohONXwf9S0ODfSFcBpiYpW8y BBSn6dcfXS5Y4BehVrt19omgOSd6WNHRClZF5T9ryPa4G52GR9SWJn4MODUk5/Hg 3AiyfyXcc+KLDHD52fMQXJ0xoUYQqNyMSjI4G8D6Gyhp+rdd4c+WMbOJzCb/XaHl puxTJtkr0+799EjoCh2aBVX/RvVYGwiYiEiDGlC2Pyuxo2EFaYSVg1Nhl3CVJ2R5 jUQUofhsONe73ZnnefRlQyLOYvrk/bCxTJZIcNNWa2seq+FBv6WrVQ4JUvwEweZf H/VA2EuIkPkwsLbzozsPNdaRKUm7CMq6FAcvhB77YPULNj7bOPlXjOeBrrZRuLez VHx+7q32MjZNh05ZlIlbjbr1elC827Y0g2oMdnYoqk+dUDQF5oBRevnM+5fTSfGG 8cltMO0ir1XqybJRBYK87bveATl3IoUilcez7OMCAM2KthF2UCQ9V1IGpoT2nH5S Iv/xgtHhEVDyhBJ/xe5k/cXhlileLbjDdu9xt0mOVmxo4wlVBjizL5Zt9XcL9+vL Y+0JYvvRzj6Q9Dm6Pcy4 =TpbW -----END PGP SIGNATURE----- --=-=-=--