From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755072Ab0DRT1r (ORCPT ); Sun, 18 Apr 2010 15:27:47 -0400 Received: from icebox.esperi.org.uk ([81.187.191.129]:42194 "EHLO mail.esperi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167Ab0DRT1p (ORCPT ); Sun, 18 Apr 2010 15:27:45 -0400 To: Trond Myklebust Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: 2.6.34rc4 NFS writeback regression (bisected): client often fails to delete things it just created References: <87tyr9dfvv.fsf@spindle.srvr.nix> <1271618484.8049.1.camel@localhost.localdomain> From: Nix Emacs: resistance is futile; you will be assimilated and byte-compiled. Date: Sun, 18 Apr 2010 20:27:19 +0100 In-Reply-To: <1271618484.8049.1.camel@localhost.localdomain> (Trond Myklebust's message of "Sun, 18 Apr 2010 15:21:24 -0400") Message-ID: <87vdboa7e0.fsf@spindle.srvr.nix> User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.5-b29 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-DCC-URT-Metrics: spindle 1060; Body=3 Fuz1=3 Fuz2=3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18 Apr 2010, Trond Myklebust verbalised: > On Sat, 2010-04-17 at 20:43 +0100, Nix wrote: >> I suspect that unlink()ing a not otherwise open file for which writeback >> is still underway is causing the files to be sillyrenamed because >> writeback is holding them open. If writeback is the only user, they >> should surely not be held open: nobody cares what their contents are, >> and a lot of code depends on rm -r of directories containing recently- >> written-but-still-closed files succeeding. > > Did you test with commit b80c3cb628f0ebc241b02e38dd028969fb8026a2 (NFS: > Ensure that writeback_single_inode() calls write_inode() when syncing)? > That fixed the above problem on my setup. tip-of-tree includes that commit, and it's still happening for me there. (Just verified again.) (The exported filesystem is coming from a box running 2.6.33 atop ext4, in case it matters.)