From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767B6C46467 for ; Mon, 28 Nov 2022 11:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbiK1LRT (ORCPT ); Mon, 28 Nov 2022 06:17:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbiK1LRQ (ORCPT ); Mon, 28 Nov 2022 06:17:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3754E6172; Mon, 28 Nov 2022 03:17:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD4316106C; Mon, 28 Nov 2022 11:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24DD3C433D7; Mon, 28 Nov 2022 11:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669634234; bh=xJRkcM/s19gYAXNwC6geD/5BTDYu4MnGAhHKzNufA+0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Zc3z3ZpSWt3HdcyaFQb77lXWXGjgErqrJLoSYdVZXy55Aku3lOHxFJeoyY+mqiho9 FpATB+axPKq/E+U+UnKlRr+Z6LW3qFLAwE3sQgQO5PEL+DJmn9VpqYxW7ujWqypOgv SRFrEK4IkYwYcrQSVYVpdZyynw163vlOh2qv4cHcMmxWkojKIeSrpsrxc13CndztAO EDWWNA7nvxDsYGAxW0IOKWxq7S3E+8/cV0OLh5Ehj5/XskASIiV1w4RNcqqNWs/31u WY8q5uxsB6ch/bCuMWP6ZDQnuifHYj6zXndMSfeu38QkSPTW71cgLsdtk43eW+2p+i d7fB78QwN1GfA== From: Kalle Valo To: Linus Walleij Cc: Konrad Dybcio , Alvin =?utf-8?Q?=C5=A0iprag?= =?utf-8?Q?a?= , Hector Martin , "~postmarketos\/upstreaming\@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "martin.botka\@somainline.org" , "angelogioacchino.delregno\@somainline.org" , "marijn.suijten\@somainline.org" , "jamipkettunen\@somainline.org" , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , "Zhao\, Jiaqing" , "Russell King \(Oracle\)" , Soon Tak Lee , "linux-wireless\@vger.kernel.org" , "brcm80211-dev-list.pdl\@broadcom.com" , "SHA-cyfmac-dev-list\@infineon.com" , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> <0e65a8b2-0827-af1e-602c-76d9450e3d11@marcan.st> <7fd077c5-83f8-02e2-03c1-900a47f05dc1@somainline.org> <20220922133056.eo26da4npkg6bpf2@bang-olufsen.dk> <87sfke32pc.fsf@kernel.org> <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> <87fse76yig.fsf@kernel.org> <87bkov6x1q.fsf@kernel.org> Date: Mon, 28 Nov 2022 13:17:06 +0200 In-Reply-To: (Linus Walleij's message of "Sat, 26 Nov 2022 22:45:33 +0100") Message-ID: <87wn7f5nwt.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Walleij writes: >> >> Instead of a directory path ("brcm/brcmfmac43596-pcie") why not provide >> >> just the chipset name ("brcmfmac43596-pcie")? IMHO it's unnecessary to >> >> have directory names in Device Tree. >> > >> > I think it's common practice to include a full $FIRMWARE_DIR-relative >> > path when specifying firmware in DT, though here I left out the board >> > name bit as that's assigned dynamically anyway. That said, if you don't >> > like it, I can change it. >> >> It's just that I have understood that Device Tree is supposed to >> describe hardware and to me a firmware directory "brcm/" is a software >> property, not a hardware property. But this is really for the Device >> Tree maintainers to decide, they know this best :) > > I would personally just minimize the amount of information > put into the device tree to be exactly what is needed to find > the right firmware. > > brcm,firmware-compatible = "43596"; > > since the code already knows how to conjure the rest of the string. FWIW I like this. > But check with Rob/Krzysztof. Indeed, they are the experts here. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches