From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613E4C432BE for ; Thu, 12 Aug 2021 14:45:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DFF3610A5 for ; Thu, 12 Aug 2021 14:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238120AbhHLOqX (ORCPT ); Thu, 12 Aug 2021 10:46:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:58392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235298AbhHLOqS (ORCPT ); Thu, 12 Aug 2021 10:46:18 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AE93610A4; Thu, 12 Aug 2021 14:45:53 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mEBxv-004Zhc-8x; Thu, 12 Aug 2021 15:45:51 +0100 Date: Thu, 12 Aug 2021 15:45:50 +0100 Message-ID: <87wnoq90wx.wl-maz@kernel.org> From: Marc Zyngier To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [PATCH v3 05/13] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() In-Reply-To: <875ywa944c.mognet@arm.com> References: <20210629125010.458872-1-valentin.schneider@arm.com> <20210629125010.458872-6-valentin.schneider@arm.com> <87bl639l8n.wl-maz@kernel.org> <875ywa944c.mognet@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, lorenzo.pieralisi@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Aug 2021 14:36:35 +0100, Valentin Schneider wrote: > > On 12/08/21 08:26, Marc Zyngier wrote: > > On Tue, 29 Jun 2021 13:50:02 +0100, > > Valentin Schneider wrote: > >> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > >> index ef30b4762947..e6d6d32ddcbc 100644 > >> --- a/kernel/irq/manage.c > >> +++ b/kernel/irq/manage.c > >> @@ -1107,7 +1107,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, > >> desc->threads_oneshot &= ~action->thread_mask; > >> > >> if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && > >> - irqd_irq_masked(&desc->irq_data)) > >> + (irqd_irq_masked(&desc->irq_data) | irqd_irq_flow_masked(&desc->irq_data))) > >> unmask_threaded_irq(desc); > > > > The bitwise OR looks pretty odd. It is probably fine given that both > > side of the expression are bool, but still. I can fix this locally. > > > > Thomas suggested that back in v1: > > https://lore.kernel.org/lkml/87v98v4lan.ffs@nanos.tec.linutronix.de/ > > I did look at the (arm64) disassembly diff back then and was convinced by > what I saw, though I'd have to go do that again as I can't remember much > else. Ah, fair enough. Thanks, M. -- Without deviation from the norm, progress is not possible.