linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Stephen Boyd <swboyd@chromium.org>,
	Xin He <hexin.op@bytedance.com>,
	keescook@chromium.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugobjects: add missing empty function debug_object_active_state()
Date: Sat, 19 Jun 2021 18:47:25 +0200	[thread overview]
Message-ID: <87wnqpdco2.ffs@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAE-0n51T9ZGADCk6LaKJdnQwPvMCawSvjwUP+AF0hFohAFom0A@mail.gmail.com>

On Fri, Jun 18 2021 at 22:03, Stephen Boyd wrote:
> Quoting Xin He (2021-06-17 00:10:27)
>> All other functions are defined for when CONFIG_DEBUG_OBJECTS
>> is not set.
>>
>> Signed-off-by: Xin He <hexin.op@bytedance.com>
>> ---
>>  include/linux/debugobjects.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/include/linux/debugobjects.h b/include/linux/debugobjects.h
>> index 8d2dde23e9fb..af0d73d8d29b 100644
>> --- a/include/linux/debugobjects.h
>> +++ b/include/linux/debugobjects.h
>> @@ -99,6 +99,9 @@ static inline void
>>  debug_object_free      (void *addr, const struct debug_obj_descr *descr) { }
>>  static inline void
>>  debug_object_assert_init(void *addr, const struct debug_obj_descr *descr) { }
>> +static inline void
>> +debug_object_active_state(void *addr, const struct debug_obj_descr *descr,
>> +                         unsigned int expect, unsigned int next) { }
>
> I suppose it's a landmine that may go off at some point, but this isn't
> fixing anything that's broken at the moment, correct?

The two users (RCU/i915) have it guarded with RCU/I915 specific config
options which depend on CONFIG_DEBUG_OBJECTS.

I have no problem with the patch per se, but it want's a proper use case.

Thanks,

        tglx




  reply	other threads:[~2021-06-19 16:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  7:10 [PATCH] debugobjects: add missing empty function debug_object_active_state() Xin He
2021-06-19  5:03 ` Stephen Boyd
2021-06-19 16:47   ` Thomas Gleixner [this message]
2021-06-20  5:52     ` [External] " 何鑫
2021-06-20 11:09       ` Thomas Gleixner
2021-06-20  5:40   ` 何鑫

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnqpdco2.ffs@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=hexin.op@bytedance.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).