From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525C2C4727E for ; Thu, 1 Oct 2020 22:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B58C206DB for ; Thu, 1 Oct 2020 22:05:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="hYSZvjIl"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="f/HNZgTj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733112AbgJAWF4 (ORCPT ); Thu, 1 Oct 2020 18:05:56 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:38558 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgJAWF4 (ORCPT ); Thu, 1 Oct 2020 18:05:56 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601589954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJcSELVC6RVckkFldDPnK0A/9qc4egUUwNfx1N3iMQ0=; b=hYSZvjIlCvJp6mhe7Ze4zibnAoIQOm2HevzvHSTiOeN8BpodcJvTPOuz31EbixqHdWELLE h/fxpyGgqeiGzyq75iyf4VmXZBeVYzcjwG1nHRj1+VtXvK2VGBMj02Mlj7Mn8k0ss0epVx mARL5Iq0k52AKNQyYoXhbz/Puy1xebrCQU5EQGIt2k0BK1pAfP2AUs4oo3JDbXprtab5wx qx+4ik/A/lOLcxErJ0EWWvYlZ1C5kBB5NVCpRl3ShcdYPjqYhzgiGCbVqljHw+JvTpapkb 7DOa+taRH5pokl0L63jsE5oEtySdzZxOasa33MR4NDKLHB5xLUlHSN8D9ZHEIw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601589954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJcSELVC6RVckkFldDPnK0A/9qc4egUUwNfx1N3iMQ0=; b=f/HNZgTj8Ox4bFry60y8Ijfmnnofa+tIHeeS7NaMjPdbIkdsotWtlwm6bSwY+Yw9N1asTm QnMhcuUBaEDU3HAg== To: Erez Geva , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Cong Wang , "David S . Miller" , Jakub Kicinski , Jamal Hadi Salim , Jiri Pirko , Andrei Vagin , Dmitry Safonov <0x7f454c46@gmail.com>, "Eric W . Biederman" , Ingo Molnar , John Stultz , Michal Kubecek , Oleg Nesterov , Peter Zijlstra , Richard Cochran , Stephen Boyd , Vladis Dronov , Sebastian Andrzej Siewior , Frederic Weisbecker , Eric Dumazet Cc: Jesus Sanchez-Palencia , Vinicius Costa Gomes , Vedang Patel , Simon Sudler , Andreas Meisinger , Andreas Bucher , Henning Schild , Jan Kiszka , Andreas Zirkler , Ermin Sakic , An Ninh Nguyen , Michael Saenger , Bernd Maehringer , Gisela Greinert , Erez Geva , Erez Geva Subject: Re: [PATCH 2/7] Function to retrieve main clock state In-Reply-To: <20201001205141.8885-3-erez.geva.ext@siemens.com> References: <20201001205141.8885-1-erez.geva.ext@siemens.com> <20201001205141.8885-3-erez.geva.ext@siemens.com> Date: Fri, 02 Oct 2020 00:05:53 +0200 Message-ID: <87wo09eh4u.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Erez, On Thu, Oct 01 2020 at 22:51, Erez Geva wrote: same comments as for patch 1 apply. > Add kernel function to retrieve main clock oscillator state. The function you are adding is named adjtimex(). adjtimex(2) is a well known user space interface and naming a read only kernel interface the same way is misleading. Thanks, tglx