linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: add 74aup1g157gw 2-input multiplexer as clock driver
Date: Fri, 12 Oct 2018 00:37:30 +0000	[thread overview]
Message-ID: <87woqoaty1.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <153923999820.207691.114282732524143268@swboyd.mtv.corp.google.com>


Hi Stephen

Thank you for your feedback

> > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > index 292056b..9cfeb0e 100644
> > --- a/drivers/clk/Kconfig
> > +++ b/drivers/clk/Kconfig
> > @@ -299,5 +299,6 @@ source "drivers/clk/sunxi-ng/Kconfig"
> >  source "drivers/clk/tegra/Kconfig"
> >  source "drivers/clk/ti/Kconfig"
> >  source "drivers/clk/uniphier/Kconfig"
> > +source "drivers/clk/nxp/Kconfig"
> 
> Please sort this alphabetically.

Will do

> >  obj-$(CONFIG_ARCH_MXS)                 += mxs/
> > -obj-$(CONFIG_COMMON_CLK_NXP)           += nxp/
> > +obj-y                                  += nxp/
> 
> There's the CONFIG_COMMON_CLK_NXP config symbol that could go into the
> drivers/clk/nxp/Kconfig file then and also wrap the Makefile contents in
> the nxp subdirectory too? We don't want to lose that config option and
> start enabling this driver all the time.

OK, will do

> Nitpick: This macro is just obfuscating, there isn't any container_of()
> usage going on so please remove it.
(snip)
> Nitpick: This macros isn't making things any shorter, so please remove
> it.

will fix

> > +static const struct clk_ops clk74_ops = {
> > +       .set_rate       = clk74_set_rate,
> > +       .round_rate     = clk74_round_rate,
> > +       .recalc_rate    = clk74_recalc_rate,
> > +       .get_parent     = clk74_get_parent,
> > +};
> 
> Can this all be handled by the 'gpio-mux-clock' compatible/driver? I
> suppose it may need an update to add the rounding policy that you want
> via some sort of DT property, but otherwise it would be fine?

Hmm.. not sure.
If we can add new feature (= .round_rate ?) on gpio-mux-clock,
I can consider it.

> You mean -ENOMEM?
(snip)
> Please return actual error code instead of overriding and returning
> probe defer.
(snip)
> Please return the actual error.
(snip)
> Please remove noise like this.
(snip)
> Nitpick: I'd prefer to not have the macro.

will fix

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2018-10-12  0:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  2:15 [PATCH 0/2] " Kuninori Morimoto
2018-10-10  2:16 ` [PATCH 1/2] dt-bindings: clock: add description of 74aup1g157gw Kuninori Morimoto
2018-10-17 16:05   ` Rob Herring
2018-10-18  0:15     ` Kuninori Morimoto
2018-10-10  2:16 ` [PATCH 2/2] clk: add 74aup1g157gw 2-input multiplexer as clock driver Kuninori Morimoto
2018-10-11  6:39   ` Stephen Boyd
2018-10-12  0:37     ` Kuninori Morimoto [this message]
2018-10-12 16:06       ` Stephen Boyd
2018-10-14 23:53         ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woqoaty1.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --subject='Re: [PATCH 2/2] clk: add 74aup1g157gw 2-input multiplexer as clock driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).