From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C527FC46460 for ; Wed, 15 Aug 2018 10:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 781792168C for ; Wed, 15 Aug 2018 10:02:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 781792168C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729002AbeHOMy0 (ORCPT ); Wed, 15 Aug 2018 08:54:26 -0400 Received: from ozlabs.org ([203.11.71.1]:38777 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbeHOMy0 (ORCPT ); Wed, 15 Aug 2018 08:54:26 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 41r4lZ6wB5z9s4c; Wed, 15 Aug 2018 20:02:50 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Jiri Olsa , Arnaldo Carvalho de Melo Cc: Jiri Olsa , Ingo Molnar , Peter Zijlstra , namhyung@kernel.org, dsahern@gmail.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, alexander.kapshuk@gmail.com Subject: Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir In-Reply-To: <20180814231120.GB3180@krava> References: <20180811083915.17471-1-alexander.kapshuk@gmail.com> <20180813111504.3568-1-jolsa@kernel.org> <87mutplnwk.fsf@concordia.ellerman.id.au> <20180814072726.GA13931@krava> <20180814180644.GA24338@kernel.org> <20180814231120.GB3180@krava> Date: Wed, 15 Aug 2018 20:02:48 +1000 Message-ID: <87wossaqwn.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Olsa writes: > On Tue, Aug 14, 2018 at 03:06:44PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Tue, Aug 14, 2018 at 09:27:26AM +0200, Jiri Olsa escreveu: >> > On Tue, Aug 14, 2018 at 11:47:39AM +1000, Michael Ellerman wrote: >> > > Jiri Olsa writes: >> > > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh >> > > > index ea48aa6f8d19..9d466e853aec 100755 >> > > > --- a/tools/perf/check-headers.sh >> > > > +++ b/tools/perf/check-headers.sh >> > > > @@ -88,6 +88,8 @@ check () { >> > > > # differences. >> > > > test -d ../../include || exit 0 >> > > > >> > > > +pushd ../.. > /dev/null >> > > > + >> > > > # simple diff check >> > > > for i in $HEADERS; do >> > > > check $i -B >> > > >> > > This breaks the build when sh is not bash: >> > > >> > > ./check-headers.sh: 91: ./check-headers.sh: pushd: not found >> > > ./check-headers.sh: 107: ./check-headers.sh: popd: not found >> > > Makefile.perf:205: recipe for target 'sub-make' failed >> > >> > sry.. Arnaldo, would you change it for simple cd (attached below) >> > or should I send the fix? >> >> Nah, I'm folding this in, to keep it bisectable. > > any chance one of your docker tests could run build in sh/zsh? ;-) Just using an Ubuntu image, where /bin/sh == dash should work, that's how I hit it. cheers