From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdECQD3 (ORCPT ); Wed, 3 May 2017 12:03:29 -0400 Received: from anholt.net ([50.246.234.109]:48228 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdECQDY (ORCPT ); Wed, 3 May 2017 12:03:24 -0400 From: Eric Anholt To: Lucas Stach Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Russell King , Christian Gmeiner , etnaviv@lists.freedesktop.org Subject: Re: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release. In-Reply-To: <1493806760.13947.32.camel@pengutronix.de> References: <20170412191202.22740-1-eric@anholt.net> <20170412191202.22740-5-eric@anholt.net> <1493806760.13947.32.camel@pengutronix.de> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 03 May 2017 09:03:21 -0700 Message-ID: <87wp9yylkm.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Lucas Stach writes: > Hi Eric, > > Am Mittwoch, den 12.04.2017, 12:12 -0700 schrieb Eric Anholt: >> If we follow the typical pattern of the base class being the first >> member, we can use the default dma_fence_free function. > > Sorry, I don't like this change. > While it provides a bit of code simplification, it also bakes the > implicit assumption into the code that dma_fence is the first struct > member without any checks to validate this assumption. I would at least > expect a build bug assert, but then the current bit of code to keep this > explicit and self-documenting is probably just as good. Fine with me. Please make sure you grab patch 2, though. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkJ/0kACgkQtdYpNtH8 nuhu7RAAipvY0EE08VSbRJqUlnaE2Hd4WXyvyWTqfIPCpjGL1wA4XC9I7KZVqYM9 xhIZ4l6shsgxJkysVXQZC4RPEsAeQDD5S8baGDJR56dzjjeINLmLpR5NfVMMNn3g Di1ACfmQ5wABgsaaQo+EFLpYkIHNl+xBYAHbuGrK6WLmyOAAwO2VjBJ19MZepD1k Q6omMmzgWyvNO1TDK2HbNCLm4ZC08tul+LhzPZbu6uNDZ7AHtDAjhDVWCuSTVEG2 jKAzQLlYC4DENddGwjZFagaaQXbk+ThJy9jdsmcxWVSPxg/yEVaOrMFXyxxfWJGA rSoBvqf8i0Qq1caSCYb+vC7qwfiJrpjBE2dBxFxJvmQVdtmf705gFd4HcRNbVqOa ukJwoyNJIGr6ATn+1tWqnEW1tQuzEdJk39EXZFc9Qar1//VP/F2vQTTjoZgyyHvP QxV2vw6MFfMft26eWwHw8K+d/mogUnZcBiYO0epBqVNZ9cHRU/1lDwYCe5j76fm0 JLVLQ46h8/bN0N3vJiYjzT4P4JSb6iMpWXiy0ZcZ0ycWuwqiWbEzXQZrzWfOKByO 2CmJo4UkvyxAxk7PWacu3eVRPZObakJun0D+7d6t0KeHK60U5Fm7DHwXxv7q60eN /qjKpjIrv5oJNSpVT+ZVOBPB+GU7g9ylXt8kazlAYebiuDrAHc8= =rAqr -----END PGP SIGNATURE----- --=-=-=--