From: Eric Anholt <email@example.com> To: Daniel Vetter <firstname.lastname@example.org> Cc: dri-devel <email@example.com>, Rob Herring <firstname.lastname@example.org>, Mark Rutland <email@example.com>, "devicetree\@vger.kernel.org" <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com> Subject: Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Date: Fri, 21 Apr 2017 15:53:30 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAKMK7uHBE1Qtjr2dM3U9edEfZ0mXVEjcw+hs8mF9ZkRP4Vcm=A@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1635 bytes --] Daniel Vetter <email@example.com> writes: > On Wed, Apr 19, 2017 at 7:55 PM, Eric Anholt <firstname.lastname@example.org> wrote: >> Daniel Vetter <email@example.com> writes: >>> On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt <firstname.lastname@example.org> wrote: >>>> The FBDEV initialization would throw an error in dmesg, when we just >>>> want to silently not initialize fbdev on a V3D-only VC4 instance. >>>> >>>> Signed-off-by: Eric Anholt <email@example.com> >>> >>> Hm, this shouldn't be an error really, you might want to hotplug more >>> connectors later on. What exactly complains? >> >> drm_fb_helper_init() throws an error if the passed in connector count is >> 0, so drm_fb_cma_helper() printks an error. > > Oh, _that_ thing. The error in there is correct, but (almost) everyone > gets this parameter wrong. This isn't the max number of connectors the > fb helper will light up, but just the max number of connectors _per_ > crtc when driving in hw clone mode. There's two problems with that: > - fb helpers don't support hw clone mode, we select 1:1 crtcs for each > active connector > - I mentioned that everyone gets this wrong? > > If you're moderately bored it'd be great to nuke the max_connector > argument from drm_fb_helper_init, and hard-code it to 1 (with a big > comment explaining that this needs to be changed, probably with > dynamic reallocation, once someone gets around to implementing hw > clone mode). > > If you're less bored, just hardcode this to 1 in vc4 and done. Plus a > TODO.rst entry would be great in that case. If I'm driving a GPU with no display subsystem at all, it seems like I shouldn't initialize fbdev for it, right? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-21 22:53 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-18 19:11 [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime Eric Anholt 2017-04-18 19:11 ` [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D Eric Anholt 2017-04-19 4:59 ` Daniel Vetter 2017-04-19 17:55 ` Eric Anholt 2017-04-19 19:36 ` Daniel Vetter 2017-04-21 22:53 ` Eric Anholt [this message] 2017-04-24 14:26 ` Alex Deucher 2017-05-02 8:16 ` Daniel Vetter 2017-04-18 19:11 ` [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus Eric Anholt 2017-04-20 20:33 ` Rob Herring 2017-04-18 19:23 ` [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime Eric Anholt 2017-04-18 23:38 ` [PATCH 1/3 v2] " Eric Anholt 2017-04-18 23:48 ` Florian Fainelli 2017-04-19 0:02 ` Eric Anholt 2017-04-19 0:02 ` Eric Anholt 2017-04-24 20:12 ` [PATCH 1/3 v3] " Eric Anholt 2017-04-28 18:29 ` Rob Herring 2017-04-28 21:41 ` Eric Anholt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/3] drm/vc4: Don'\''t try to initialize FBDEV if we'\''re only bound to V3D.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).