From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcHRGdv (ORCPT ); Thu, 18 Aug 2016 02:33:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:64781 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbcHRGdu (ORCPT ); Thu, 18 Aug 2016 02:33:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,537,1464678000"; d="asc'?scan'208";a="750288538" From: Felipe Balbi To: Peter Chen Cc: Heikki Krogerus , Greg KH , Guenter Roeck , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY In-Reply-To: <20160817230058.GA26420@shlinux2> References: <1471430081-12860-1-git-send-email-heikki.krogerus@linux.intel.com> <1471430081-12860-3-git-send-email-heikki.krogerus@linux.intel.com> <87d1l77e0r.fsf@linux.intel.com> <20160817230058.GA26420@shlinux2> User-Agent: Notmuch/0.22.1+63~g994277e (https://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu) Date: Thu, 18 Aug 2016 09:33:33 +0300 Message-ID: <87wpje60xu.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Peter Chen writes: > On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Heikki Krogerus writes: >>=20 >> [...] >>=20 >> > +static struct platform_driver wcove_typec_driver =3D { >> > + .driver =3D { >> > + .name =3D "bxt_wcove_usbc", >> > + }, >> > + .probe =3D wcove_typec_probe, >> > + .remove =3D wcove_typec_remove, >> > +}; >> > + >> > +module_platform_driver(wcove_typec_driver); >> > + >> > +MODULE_AUTHOR("Intel Corporation"); >> > +MODULE_LICENSE("GPL v2"); >> > +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver"); >>=20 >> you need to add: >>=20 >> MODULE_ALIAS("platform:bxt_wcove_usbc"); >>=20 >> otherwise this won't probe() automagically. >>=20 > > What do you mean, Felipe? If there is a platform device named > "bxt_wcove_usbc", why it will not be probed? IIRC default module alias is added based on file name, not platform_driver name, so this would be MODULE_ALIAS("platform:typec_wcove") by default... I could be wrong, really don't remember the details of that now. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJXtVa9AAoJEIaOsuA1yqREu+kQAK18LDXtBJrEVXzSg7mK0Rfn 8H+38L9LLPa0SpCMjlx9eFHUrlfqZdeZUCEY3Y6wfFgj0rT2YPMM90Rs1roNjUfd wriC63T54C8q1mqYu77MUWmsSkvfM5z5JNnNh1suKQ7aHufQOI70x5H+ZZE7NhPW O3vxSKcFD3Z8WchUxw/jIYbw4DPcXc00XJrnlkuvJ1aUfKs9BYUem92sqoWAvpAz GXGSRDOjnla8nQKVcGAav4rh4fTigpHQUOPz2wGTFQL69dsB2K5aAORPP3VGWqZi 9bRl1jU95X9he1DKobYHY2wEJQKpZQyfs/f6u/6O7p2wd9hiedQ6QtMpD8Skk6zU vuvDrOXJN8HqaTWxpVjBqt5m+02Uf88aNq/mO6KfNXOtDdk99D905WVu54q8LN67 qNrd/o8MpQiweW9hEx+c88roaq7lQeP6KeqnUfma48YxjQo2MYfmJYpqB89FoeoA cm8bZ6UNe8+07K/JzElnsz+SbZ786MWi3WciIiRhKTGh3Pa2Rt6qX/gxob4o4TJp qy0fY9ik0NG7mGkJb8kUePvJydxUWqctlTlkpPy+4qZ96cAUtw6m2RKBBXHxfjrQ Dr8m8cxBnC12RADrnR9kzsYFWI7ZN68BAFGbJVG2COjHd5xgizSpT79n9uWYbYoo lXg85bEeRFJHSE9IYUJY =WafU -----END PGP SIGNATURE----- --=-=-=--