From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbcGCLex (ORCPT ); Sun, 3 Jul 2016 07:34:53 -0400 Received: from mail2.asahi-net.or.jp ([202.224.39.198]:10064 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbcGCLev (ORCPT ); Sun, 3 Jul 2016 07:34:51 -0400 Date: Sun, 03 Jul 2016 20:34:27 +0900 Message-ID: <87wpl3rm4c.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Geert Uytterhoeven Cc: "devicetree@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 14/22] sh: SH7751 core dtsi In-Reply-To: References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 01 Jul 2016 17:57:00 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato > wrote: > > SH7751 core and internal peripheral define. > > Thanks for your patch! > > > Changes v4 > > - remove unneeded #address-cells and #size-cells > > - add missing dt-binding link > > Please move changelog information below the three dashes... > > > > > Signed-off-by: Yoshinori Sato > > --- > > ... i.e. here. OK. > > --- /dev/null > > +++ b/arch/sh/boot/dts/include/dt-bindings > > @@ -0,0 +1 @@ > > +../../../../../include/dt-bindings > > \ No newline at end of file > > Missing newline. This file is symbolic link. I think not need newline. > > --- /dev/null > > +++ b/arch/sh/boot/dts/sh7751.dtsi > > > + oclk: oscillator { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <0>; > > + }; > > + cpg: cpg@ffc00000 { > > clock-controller@ffc00000 OK. > > \ No newline at end of file > > Missing newline. OK. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Yoshinori Sato