linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Brian Masney <bmasney@redhat.com>, sboyd@kernel.org
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	mturquette@baylibre.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: clk: add documentation to log which clocks have been disabled
Date: Thu, 20 Apr 2023 10:15:56 -0600	[thread overview]
Message-ID: <87y1mmsf5v.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230411192153.289688-1-bmasney@redhat.com>

Brian Masney <bmasney@redhat.com> writes:

> The existing clk documentation has a section that talks about the
> clk_ignore_unused kernel parameter. Add additional documentation that
> describes how to log which clocks the kernel disables on bootup. This
> will log messages like the following to the console on bootup:
>
>     [    1.268115] clk: Disabling unused clocks
>     [    1.272167] clk_disable: gcc_usb_clkref_en
>     [    1.276389] clk_disable: gcc_usb30_sec_sleep_clk
>     [    1.281131] clk_disable: gcc_usb30_prim_sleep_clk
>     ...
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  Documentation/driver-api/clk.rst | 5 +++++
>  1 file changed, 5 insertions(+)

I've applied this, but...

> diff --git a/Documentation/driver-api/clk.rst b/Documentation/driver-api/clk.rst
> index 3cad45d14187..2199c0042e75 100644
> --- a/Documentation/driver-api/clk.rst
> +++ b/Documentation/driver-api/clk.rst
> @@ -258,6 +258,11 @@ clocks properly but rely on them being on from the bootloader, bypassing
>  the disabling means that the driver will remain functional while the issues
>  are sorted out.
>  
> +You can see which clocks have been disabled by booting your kernel with these
> +parameters:

...I took the liberty of making that "parameters::" so that the options
would be formatted as a literal block.

> + tp_printk trace_event=clk:clk_disable
> +
>  To bypass this disabling, include "clk_ignore_unused" in the bootargs to the
>  kernel.

Thanks,

jon

      reply	other threads:[~2023-04-20 16:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 19:21 [PATCH] docs: clk: add documentation to log which clocks have been disabled Brian Masney
2023-04-20 16:15 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1mmsf5v.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=bmasney@redhat.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).