From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58827C433F5 for ; Mon, 11 Oct 2021 08:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37DC3600CD for ; Mon, 11 Oct 2021 08:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234898AbhJKIRR (ORCPT ); Mon, 11 Oct 2021 04:17:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:47362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbhJKIRP (ORCPT ); Mon, 11 Oct 2021 04:17:15 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F02A60ED4; Mon, 11 Oct 2021 08:15:16 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mZqSo-00FxTa-3C; Mon, 11 Oct 2021 09:15:14 +0100 Date: Mon, 11 Oct 2021 09:15:13 +0100 Message-ID: <87y270ou3y.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h In-Reply-To: <20211007233439.1826892-4-rananta@google.com> References: <20211007233439.1826892-1-rananta@google.com> <20211007233439.1826892-4-rananta@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, pbonzini@redhat.com, drjones@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, pshier@google.com, ricarkol@google.com, oupton@google.com, reijiw@google.com, jingzhangos@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Raghavendra, On Fri, 08 Oct 2021 00:34:27 +0100, Raghavendra Rao Ananta wrote: > > Make use of the register read/write definitions from > sysreg.h, instead of the existing definitions. A syntax > correction is needed for the files that use write_sysreg() > to make it compliant with the new (kernel's) syntax. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Oliver Upton > Reviewed-by: Andrew Jones > --- > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > 2 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > index e5e6c92b60da..11fd23e21cb4 100644 > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > { > asm volatile("msr daifset, #8"); > > - write_sysreg(osdlr_el1, 0); > - write_sysreg(oslar_el1, 0); > + write_sysreg(0, osdlr_el1); > + write_sysreg(0, oslar_el1); The previous patch has obviously introduced significant breakage which this patch is now fixing. In the interval, the build is broken, which isn't great. You can either rework this series to work around the issue, or I can squash patches #2 and #3 together. Thanks, M. -- Without deviation from the norm, progress is not possible.