From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: peterx@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()
Date: Thu, 02 Sep 2021 18:33:44 +0200 [thread overview]
Message-ID: <87y28flyxj.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20210901230506.13362-1-peterx@redhat.com>
Peter Xu <peterx@redhat.com> writes:
> Drop the unused function as reported by test bot.
Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
reallity you drop "kvm_dirty_gfn_invalid()".
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> virt/kvm/dirty_ring.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
> index 7aafefc50aa7..88f4683198ea 100644
> --- a/virt/kvm/dirty_ring.c
> +++ b/virt/kvm/dirty_ring.c
> @@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
> gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
> }
>
> -static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
> -{
> - return gfn->flags == 0;
> -}
> -
> static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
> {
> return gfn->flags & KVM_DIRTY_GFN_F_RESET;
--
Vitaly
next prev parent reply other threads:[~2021-09-02 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 23:05 [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Peter Xu
2021-09-02 16:33 ` Vitaly Kuznetsov [this message]
2021-09-02 16:40 ` Sean Christopherson
2021-09-02 16:46 ` Vitaly Kuznetsov
2021-09-02 19:53 ` Peter Xu
2021-09-02 20:13 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y28flyxj.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).