* [PATCH linux-next] net:wireless:mt76: fix boolreturn.cocci warnings
@ 2021-08-20 2:41 jing yangyang
2021-08-21 10:10 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: jing yangyang @ 2021-08-20 2:41 UTC (permalink / raw)
To: Felix Fietkau
Cc: Lorenzo Bianconi, Ryder Lee, Kalle Valo, David S . Miller,
Jakub Kicinski, Matthias Brugger, Sean Wang, Colin Ian King,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, jing yangyang, Zeal Robot
./drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c:172:8-9:WARNING:
return of 0/1 in function 'mt7663_usb_sdio_tx_status_data' with return
type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
---
drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c b/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c
index 996d48c..bd2939e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c
@@ -169,7 +169,7 @@ bool mt7663_usb_sdio_tx_status_data(struct mt76_dev *mdev, u8 *update)
mt7615_mac_sta_poll(dev);
mt7615_mutex_release(dev);
- return 0;
+ return false;
}
EXPORT_SYMBOL_GPL(mt7663_usb_sdio_tx_status_data);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] net:wireless:mt76: fix boolreturn.cocci warnings
2021-08-20 2:41 [PATCH linux-next] net:wireless:mt76: fix boolreturn.cocci warnings jing yangyang
@ 2021-08-21 10:10 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-21 10:10 UTC (permalink / raw)
To: jing yangyang
Cc: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, David S . Miller,
Jakub Kicinski, Matthias Brugger, Sean Wang, Colin Ian King,
linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel, jing yangyang, Zeal Robot
jing yangyang <cgel.zte@gmail.com> writes:
> ./drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c:172:8-9:WARNING:
> return of 0/1 in function 'mt7663_usb_sdio_tx_status_data' with return
> type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/usb_sdio.c | 2 +-
The subject should be:
mt76: mt7615: fix boolreturn.cocci warnings
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-21 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 2:41 [PATCH linux-next] net:wireless:mt76: fix boolreturn.cocci warnings jing yangyang
2021-08-21 10:10 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).