From: ebiederm@xmission.com (Eric W. Biederman)
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+b6e65bd125a05f803d6b@syzkaller.appspotmail.com>,
legion@kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] KASAN: use-after-free Write in put_ucounts
Date: Tue, 20 Jul 2021 11:29:09 -0500 [thread overview]
Message-ID: <87y2a1q78q.fsf@disp2133> (raw)
In-Reply-To: <20210720041451.766-1-hdanton@sina.com> (Hillf Danton's message of "Tue, 20 Jul 2021 12:14:51 +0800")
Hillf Danton <hdanton@sina.com> writes:
> On Mon, 19 Jul 2021 12:24:41 -0500 Eric W. Biederman wrote:
>>>
>>> To fix the uaf, add a couple of changes. Now only for thoughts.
>>>
>>> 1/ s/atomic_add_negative/atomic_inc_not_zero/ to correct the get
>>> method.
>>
>>I really don't think so. The use of atomic_add_negative is very
>>deliberate. Changing that fundamentally changes the algorithm into used
>
> Given atomic_dec_and_test() in put_ucounts(), what sense are you
> deliberately trying to make by bumping up a zero count?
>
>>to keep track of things. Definitely not something to lead with.
>>
>>Before it even makes sense to talk about how to change the code,
>>a plausible explanation for how a use after free happens is needed.
>
> I am trying just to avoid touching zero count. That is it.
Observing a zero-reference count in this case is a result of a
use-after-free. So that is definitely not what needs to be fixed.
>>That explanation should account for the fact this code was in linux-next
>>the since last -rc1 without any kind of issue with the test code.
>
> The code is no good without surviving syzbot, right? And -rcX does not
> matter.
That was with syzbot running against linux-next for 8ish weeks.
Something changed that syzbot is now reporting an error.
It is definitely worth fixing but we need to track down and understand
what the bug is.
Eric
next prev parent reply other threads:[~2021-07-20 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 6:22 [syzbot] KASAN: use-after-free Write in put_ucounts syzbot
[not found] ` <20210719094432.425-1-hdanton@sina.com>
2021-07-19 17:24 ` Eric W. Biederman
2021-07-24 17:57 ` Alexey Gladkov
[not found] ` <20210720041451.766-1-hdanton@sina.com>
2021-07-20 16:29 ` Eric W. Biederman [this message]
2021-07-27 15:24 ` [PATCH v1] ucounts: Fix race condition between alloc_ucounts and put_ucounts Alexey Gladkov
[not found] ` <20210728025837.1641-1-hdanton@sina.com>
2021-07-28 12:24 ` Alexey Gladkov
2021-07-28 17:05 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2a1q78q.fsf@disp2133 \
--to=ebiederm@xmission.com \
--cc=hdanton@sina.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+b6e65bd125a05f803d6b@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).