From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B339EC43381 for ; Wed, 3 Feb 2021 22:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82E0A64F60 for ; Wed, 3 Feb 2021 22:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233038AbhBCWeg (ORCPT ); Wed, 3 Feb 2021 17:34:36 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:23161 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232866AbhBCWe2 (ORCPT ); Wed, 3 Feb 2021 17:34:28 -0500 Date: 04 Feb 2021 07:33:37 +0900 X-IronPort-AV: E=Sophos;i="5.79,399,1602514800"; d="scan'208";a="71248370" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 04 Feb 2021 07:33:37 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 9CCBC400F4EC; Thu, 4 Feb 2021 07:33:37 +0900 (JST) Message-ID: <87y2g494b0.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown Cc: Sameer Pujar , thierry.reding@gmail.com, jonathanh@nvidia.com, alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, sharadg@nvidia.com Subject: Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function In-Reply-To: <20210203172415.GH4880@sirena.org.uk> References: <1612368575-25991-1-git-send-email-spujar@nvidia.com> <1612368575-25991-2-git-send-email-spujar@nvidia.com> <20210203161951.GG4880@sirena.org.uk> <64b65aaf-9971-e071-5d52-02286fe0cacc@nvidia.com> <20210203172415.GH4880@sirena.org.uk> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > > > > +int graph_remove(struct platform_device *pdev); > > > > I think this needs better namespacing if it's going to be exported. > > > audio_graph_remove() can be a better choice? > > Yeah, that looks reasonable. Nice naming I think. In such case, update also graph_parse_of() is nice idea for me. - int graph_parse_of(...) + int audio_graph_parse_of() Thank you for your help !! Best regards --- Kuninori Morimoto