From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/4] iio: vcnl4000: Add event support for VCNL4010/20.
Date: Wed, 22 Apr 2020 10:02:11 +0200 [thread overview]
Message-ID: <87y2qoosn0.fsf@gmail.com> (raw)
In-Reply-To: <CAHp75Veqp=tb0Z9h2cey5DE_KpNBp3Jdmh2gLzSoo-N5CsGpvw@mail.gmail.com> (Andy Shevchenko's message of "Tue, 21 Apr 2020 14:24:30 +0300")
Hello Andy,
>> + ret = devm_request_threaded_irq(&client->dev, client->irq,
>> + NULL, vcnl4010_irq_thread,
>> + IRQF_TRIGGER_FALLING |
>
>> + IRQF_ONESHOT,
>
> Isn't it by default when threaded IRQ is asked with NULL for hw handler?
No, and it fails with this error message if IRQF_ONESHOT is not set:
pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
Thanks,
Mathieu
next prev parent reply other threads:[~2020-04-22 8:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 7:55 [PATCH v4 0/4] iio: vcnl: Add interrupts support for VCNL4010/20 Mathieu Othacehe
2020-04-21 7:55 ` [PATCH v4 1/4] iio: vcnl4000: Factorize data reading and writing Mathieu Othacehe
2020-04-21 7:55 ` [PATCH v4 2/4] iio: vcnl4000: Add event support for VCNL4010/20 Mathieu Othacehe
2020-04-21 11:24 ` Andy Shevchenko
2020-04-22 8:02 ` Mathieu Othacehe [this message]
2020-04-22 8:25 ` Andy Shevchenko
2020-04-25 19:47 ` Jonathan Cameron
2020-04-21 7:55 ` [PATCH v4 3/4] iio: vcnl4000: Add sampling frequency " Mathieu Othacehe
2020-04-21 12:22 ` Andy Shevchenko
2020-04-25 15:52 ` Jonathan Cameron
2020-04-25 17:14 ` Andy Shevchenko
2020-04-25 19:49 ` Jonathan Cameron
2020-04-21 7:55 ` [PATCH v4 4/4] iio: vcnl4000: Add buffer " Mathieu Othacehe
2020-04-21 12:27 ` Andy Shevchenko
2020-04-22 8:14 ` Mathieu Othacehe
2020-04-25 16:09 ` Jonathan Cameron
2020-04-25 15:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2qoosn0.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).