From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC40BC5DF63 for ; Wed, 6 Nov 2019 18:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C1F920869 for ; Wed, 6 Nov 2019 18:23:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YQWssHj1"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YQWssHj1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732514AbfKFSXE (ORCPT ); Wed, 6 Nov 2019 13:23:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52008 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727208AbfKFSXD (ORCPT ); Wed, 6 Nov 2019 13:23:03 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C39B46039C; Wed, 6 Nov 2019 18:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573064582; bh=f8LjsY8UAdJTWrsEXBbmOOJZMmDExAEs4UlfYAv6xAE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YQWssHj1hIp+G+mBMsNF/15B/cru208q0naT/vdBj3rtlvIu7fUahenofDI4Piq/y qNiNd1pxe245ohucnRRUocr5eajxHZz+C/KU6HmfVXMYUSzJk4WAUIv2J1th6eZERc sIcnVZfWrRrtW66MdifMuOenKtQG2c8Jv6OscM2U= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 832D860274; Wed, 6 Nov 2019 18:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573064582; bh=f8LjsY8UAdJTWrsEXBbmOOJZMmDExAEs4UlfYAv6xAE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YQWssHj1hIp+G+mBMsNF/15B/cru208q0naT/vdBj3rtlvIu7fUahenofDI4Piq/y qNiNd1pxe245ohucnRRUocr5eajxHZz+C/KU6HmfVXMYUSzJk4WAUIv2J1th6eZERc sIcnVZfWrRrtW66MdifMuOenKtQG2c8Jv6OscM2U= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 832D860274 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ikjoon Jang Cc: ath10k@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware. References: <20191101054035.42101-1-ikjn@chromium.org> Date: Wed, 06 Nov 2019 20:22:58 +0200 In-Reply-To: <20191101054035.42101-1-ikjn@chromium.org> (Ikjoon Jang's message of "Fri, 1 Nov 2019 13:40:35 +0800") Message-ID: <87y2ws3lvh.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ikjoon Jang writes: > Downloading ath10k firmware needs a large number of IOs and > cpuidle's miss predictions make it worse. In the worst case, > resume time can be three times longer than the average on sdio. > > This patch disables cpuidle during firmware downloading by > applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw(). > > Signed-off-by: Ikjoon Jang On what hardware and firmware versions did you test this? I'll add that to the commit log. https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches