From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pawel Laszczak <pawell@cadence.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com,
nsekhar@ti.com, nm@ti.com, sureshp@cadence.com,
jpawar@cadence.com, kurahul@cadence.com, aniljoy@cadence.com,
Pawel Laszczak <pawell@cadence.com>
Subject: Re: [PATCH 1/3] usb: common: Add usb_get_dr_mode_from_string and usb_dr_mode_to_string.
Date: Tue, 09 Jul 2019 09:11:59 +0300 [thread overview]
Message-ID: <87y31768k0.fsf@linux.intel.com> (raw)
In-Reply-To: <1562592924-17528-1-git-send-email-pawell@cadence.com>
Hi,
Pawel Laszczak <pawell@cadence.com> writes:
> diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> index 69f1b6328532..c156817672c4 100644
> --- a/include/linux/usb/otg.h
> +++ b/include/linux/usb/otg.h
> @@ -129,4 +129,20 @@ enum usb_dr_mode {
> */
> extern enum usb_dr_mode usb_get_dr_mode(struct device *dev);
>
> +/**
> + * usb_get_dr_mode_from_string - Convert string to dual role mode.
> + * @str: Pointer to the given string
> + *
> + * The function gets string and returns the correspondig enum usb_dr_mode.
> + */
> +extern enum usb_dr_mode usb_get_dr_mode_from_string(const char *str);
> +
> +/**
> + * usb_dr_mode_to_string - Convert dual role mode to string.
> + * @dr_mode: Pointer to the given dual role mode
> + *
> + * The function gets enum usb_dr_mode, and returns the correspondig string.
> + */
> +extern const char *usb_dr_mode_to_string(const enum usb_dr_mode dr_mode);
> +
> #endif /* __LINUX_USB_OTG_H */
Still missing the stubs I mentioned. Did you try compiling with and
without common enabled?
--
balbi
next prev parent reply other threads:[~2019-07-09 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <all>
2019-07-08 13:35 ` [PATCH 1/3] usb: common: Add usb_get_dr_mode_from_string and usb_dr_mode_to_string Pawel Laszczak
2019-07-09 6:11 ` Felipe Balbi [this message]
2019-07-09 6:23 ` Pawel Laszczak
2019-07-09 6:29 ` Felipe Balbi
2019-07-09 6:37 ` Pawel Laszczak
2019-07-21 14:54 ` Pawel Laszczak
2019-07-31 3:49 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y31768k0.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=aniljoy@cadence.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).