From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756410AbdLVQjL (ORCPT ); Fri, 22 Dec 2017 11:39:11 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56962 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbdLVQjG (ORCPT ); Fri, 22 Dec 2017 11:39:06 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171222163903euoutp014a0406c7fbf2fcdb665c0c35cb7ac7da~Cq0Zn7h8L2668426684euoutp01d X-AuditID: cbfec7f1-f793a6d00000326b-19-5a3d35267e5f From: =?utf-8?Q?=C5=81ukasz_Stelmach?= To: Philippe Ombredanne Cc: "Andrew F . Davis" , PrasannaKumar Muralidharan , Rob Herring , Matt Mackall , Herbert Xu , Krzysztof Kozlowski , Kukjin Kim , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org, LKML , Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver Date: Fri, 22 Dec 2017 17:38:56 +0100 In-reply-to: Message-id: <87y3luhg4f.fsf%l.stelmach@samsung.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-version: 1.0 Content-type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGeXfv7qY0u85VR7OCUUJG9mV0s1ZGgTeDErI/XGCOvGjk5tjS soKm5CxN51Rajcj1McOJ8wNZbqXJXE3KXCX0AXN9C6kolaZmZduugv/93nOe55yHw8vHhM+5 UfwTilOMSiHLEROhuO3JtGd9zFaJdOPgv2XU2FM9j2q51sSlal19XKpsKJrSfR7GKI+nmUe9 901zqH7HDYK65unkUI2uAR5lslUganbGrzXr3Igq7nDxEsNou3GAR9u61tCtlssEfc8eT1e0 WRBd8a0Z0e639zn0z9aVKXxp6M5MJudEPqPasCsjNLvmjh5XNkSeKWkZxDXou6gUhfCBjAeb qY7D8lJ44WsiAiwkzQheVe0vRaF+/ongYWkJMW/QOM0E26hDcN3by2Uf4wg0mufcgIogd4PO 1YkHWETGgdU8wQuIMLILh1/2ieCoCDIZnhl1QQNOrgHHiCVoCCEPQ9W9K0GNgNwCb93vsAAv IbeDr2Jgrh4OU9W+oB4j5fCjaDa4AEgrD65a3uBs1n3Q+KEIsRwBQ+42HsvR0F9dhrMGHYLu 2sm5Rg2CO7cSWd4Bfyx6gt0QBlU2gz8F318XwCWtkJXQUFhonjveHph9PICzp7iLoN06TlSi FcYFYY0Lwhr9ozByLTQ5NrDldVB3axhjWQJW6xhuQlwLEjF5ankWo94cp5bJ1XmKrLjjufJW 5P9Yz/65v7ejsZ4EJyL5SLxIYBJLpEKuLF9dIHei1f4xn5obXqAoXJGrYMQiQX7PTqlQkCkr OMuoco+p8nIYtRMt5+PiZQKJVJsmJLNkp5iTDKNkVPNdDj8kSoPqe6eTNodn/M546f08o+2Q RPbYMw+GJX8p208leBwRkd5zW9JHUtsWf7rdomo51D2q9HKO9pVrbypXrZ4J+St7bxjt1qoy Y6bKkg09+tEDT/o+GrNvX8TG+82TsZILlZ1M6sltJanp9XtTzqd7H7x21D6KL+otTjo9dSTt ZflXg1OMq7Nlm2IxlVr2H5/BnrdgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t/xq7qqprZRBs9+6Fm8PzWR3WLjjPWs FvOPnGO16H4lY9H/+DWzxfnzG9gt7t/7yWRxedccNosZ5/cxWaw9cpfdYsG2PkaL/7+Bapf2 H2e0aN17hN2Bz2PnrLvsHtsOqHpsWtXJ5rF8p4lH35ZVjB59Lzcwehy/sZ3J4/MmuQCOKC6b lNSczLLUIn27BK6MKYsnshSslqxo3/iMpYHxo0gXIyeHhICJRMOhpWwQtpjEhXvrgWwuDiGB JYwSL+eeYYZwvjFKbO46zQhSxSZgL9F/ZB8LiC0ioCexbulXdpAiZoEjLBL7pr4GSwgLeEmc ntXPCmILCQRIvLryHmwFi4CqxK43q8BqOAWCJfauesUOYvMKGEvcOH6TGcQWFbCUuNd3lw0i LijxY/I9sHpmgWyJCxffsExg5J+FJDULSWoWIweQrSmxfpc+RFhbYtnC18wQtq3EunXvWRYw sq5iFEktLc5Nzy020itOzC0uzUvXS87P3cQIjK1tx35u2cHY9S74EKMAB6MSD+8CJdsoIdbE suLK3EOMKkBjHm1YfYFRiiUvPy9VSYS37IRNlBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHe3j2r I4UE0hNLUrNTUwtSi2CyTBycUg2MiRWfr06vmZYv+ont+Dzlw8xH1h0wC5m5/UeRv8UGq5r0 rNsWdSIhXReiuW2masgXyDTEKcrKfBLepuu41uu527bAoocd2b/cbpf++6LsbWT66cqOpaoT c/o7Z5g1vt9p5chi5XCxSrE+Qvgb1y3/Z8bVKmdi406eEf6bVq/C53l6+oN9fycrsRRnJBpq MRcVJwIAGFQj/bUCAAA= X-CMS-MailID: 20171222163901eucas1p253c4258fb141ea955c40185cd2f38197 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171222163901eucas1p253c4258fb141ea955c40185cd2f38197 X-RootMTR: 20171222163901eucas1p253c4258fb141ea955c40185cd2f38197 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable It was <2017-12-22 pi=C4=85 14:34>, when Philippe Ombredanne wrote: > =C5=81ukasz, > > On Fri, Dec 22, 2017 at 2:23 PM, =C5=81ukasz Stelmach wrote: >> Add support for True Random Number Generator found in Samsung Exynos >> 5250+ SoCs. >> >> Signed-off-by: =C5=81ukasz Stelmach >> Reviewed-by: Krzysztof Kozlowski > > > >> --- /dev/null >> +++ b/drivers/char/hw_random/exynos-trng.c >> @@ -0,0 +1,245 @@ >> +/* >> + * RNG driver for Exynos TRNGs >> + * >> + * Author: =C5=81ukasz Stelmach >> + * >> + * Copyright 2017 (c) Samsung Electronics Software, Inc. >> + * >> + * Based on the Exynos PRNG driver drivers/crypto/exynos-rng by >> + * Krzysztof Koz=C5=82owski >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ > > > Would you mind using the new SPDX tags documented in Thomas patch set > [1] rather than this fine but longer legalese? > > And if you could spread the word to others in your team this would be ver= y nice. > See also this fine article posted by Mauro on the Samsung Open Source > Group Blog [2] > Thank you! Cool! We've been using SPDX to tag RPM packages in Tizen for three years or more. ;-) >> +MODULE_LICENSE("GPL"); > > Per module.h this means GPL2 or later. This is not matching your > license above which does not state any version and therefore would > mean GPL1 or later, Thanks for spotting. My intention is GPL-2.0. > Please make sure you use something and common rather than this and > make sure your MODULE_LICENSE is consistent with the top level > license. > > Was it this way in the code from Krzysztof? Yes. And omap-rng, the second of my sources of reference, too. Actually, the majority of modules still specify "GPL". 281 | "Dual */*" 2082 | "GPL v2" 6359 | "GPL" =2D--- +--------- 8784 | Total Fixing. > [1] https://lkml.org/lkml/2017/12/4/934 > [2] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/ =2D-=20 =C5=81ukasz Stelmach Samsung R&D Institute Poland Samsung Electronics --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJaPTUgAAoJELCuHpyYpYAQ/OkIAKYGU0bLnSiPYYpkSPelFEpo O9BvqvnYHbZFIuUU1OEpiJcHk2ITBFvyxAewA3+1tkwVKuY5iG2zdY3yM91PWO5Q qpyFODOfsJznEOrEI7Q81D2pzcur/Vs4fai38VqRKmDyYb7BnlPdWEl6mznT5fed GhgS9uLbOIb+UL9Nj4vBRcNoPjViZgB3rZ3xCiRHFean7mjhfK5pxedHCDmdWq4m +ZRmAaMByuxPN78gFE3ZxYIyTACNq3UFljoP0X5wJ6LT2WlSSQJ30QqmORkhs275 T7EtdjDAI2NAO9PJYzBWVwBE+Yie8sXFyuLe02fThzho+nz1nRgGz4WQ3RGdBBA= =8cE6 -----END PGP SIGNATURE----- --=-=-=--