From: ebiederm@xmission.com (Eric W. Biederman)
To: Nikolay Borisov <kernel@kyup.com>
Cc: jack@suse.cz, linux-kernel@vger.kernel.org, serge@hallyn.com,
containers@lists.linux-foundation.org
Subject: Re: [PATCH v2] inotify: Convert to using per-namespace limits
Date: Thu, 27 Oct 2016 10:46:27 -0500 [thread overview]
Message-ID: <87y419re0c.fsf@xmission.com> (raw)
In-Reply-To: <674564a4-ff05-b4d6-4a98-8cfc2e609325@kyup.com> (Nikolay Borisov's message of "Mon, 24 Oct 2016 09:47:44 +0300")
Nikolay Borisov <kernel@kyup.com> writes:
> On 10/11/2016 10:36 AM, Nikolay Borisov wrote:
>> This patchset converts inotify to using the newly introduced
>> per-userns sysctl infrastructure.
>>
>> Currently the inotify instances/watches are being accounted in the
>> user_struct structure. This means that in setups where multiple
>> users in unprivileged containers map to the same underlying
>> real user (i.e. pointing to the same user_struct) the inotify limits
>> are going to be shared as well, allowing one user(or application) to exhaust
>> all others limits.
>>
>> Fix this by switching the inotify sysctls to using the
>> per-namespace/per-user limits. This will allow the server admin to
>> set sensible global limits, which can further be tuned inside every
>> individual user namespace. Additionally, in order to preserve the
>> sysctl ABI make the existing inotify instances/watches sysctls
>> modify the values of the initial user namespace.
>>
>> Signed-off-by: Nikolay Borisov <kernel@kyup.com>
>> ---
>>
>> So here is a revised version which retains the existing sysctls,
>> and hooks them to the init_user_ns values.
>
> Gentle ping, now that rc1 has shipped and Jan's sysctl concern hopefully
> resolved.
I plan to give this a once over and merge this. I have a very funny
pile of serious bug fixes that jumped on my at the beginning of this
development cycle and a cold so I am getting to this more slowly than I
would like.
Eric
next prev parent reply other threads:[~2016-10-27 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 10:46 [PATCH] inotify: Convert to using per-namespace limits Nikolay Borisov
2016-10-07 18:14 ` Eric W. Biederman
2016-10-10 6:44 ` Nikolay Borisov
2016-10-10 16:40 ` Jan Kara
2016-10-10 20:49 ` Eric W. Biederman
2016-10-10 21:54 ` Nikolay Borisov
2016-10-10 22:39 ` Eric W. Biederman
2016-10-11 7:36 ` [PATCH v2] " Nikolay Borisov
2016-10-14 2:31 ` [lkp] [inotify] 464e1236c3: BUG kmalloc-512 (Not tainted): Freepointer corrupt kernel test robot
2016-10-24 6:47 ` [PATCH v2] inotify: Convert to using per-namespace limits Nikolay Borisov
2016-10-27 15:46 ` Eric W. Biederman [this message]
2016-12-08 1:40 ` Eric W. Biederman
2016-12-08 6:58 ` Nikolay Borisov
2016-12-08 8:14 ` Nikolay Borisov
2016-12-09 5:38 ` Eric W. Biederman
2016-12-09 2:50 ` Eric W. Biederman
2016-10-24 7:48 ` Jan Kara
2016-11-14 6:04 ` Serge E. Hallyn
2016-10-09 5:55 ` [lkp] [inotify] 1109954e99: BUG kmalloc-512 (Not tainted): Freepointer corrupt kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y419re0c.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.linux-foundation.org \
--cc=jack@suse.cz \
--cc=kernel@kyup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).