From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbcITKGA (ORCPT ); Tue, 20 Sep 2016 06:06:00 -0400 Received: from mga14.intel.com ([192.55.52.115]:25710 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932560AbcITKF7 (ORCPT ); Tue, 20 Sep 2016 06:05:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,367,1470726000"; d="scan'208";a="1059417676" From: Jani Nikula To: SF Markus Elfring , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Patrik Jakobsson Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 2/6] GPU-DRM-GMA500: Rename a jump label in mid_get_vbt_data_r10() In-Reply-To: <29c651f1-8527-0f65-0b60-3503808c9d6d@users.sourceforge.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <566ABCD9.1060404@users.sourceforge.net> <3c9785ef-4553-2e3d-2cb2-5cf6d1f31ccd@users.sourceforge.net> <29c651f1-8527-0f65-0b60-3503808c9d6d@users.sourceforge.net> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 20 Sep 2016 13:05:55 +0300 Message-ID: <87y42mlwcc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 20 Sep 2016 09:09:10 +0200 > > Adjust a jump label according to the current Linux coding style convention. Generally, please don't send patches to fix checkpatch issues in existing code. Moreover, this particular "convention" is just something someone sneaked into CodingStyle, it's subjective, and it's probably going to be removed soon. NAK. BR, Jani. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/gma500/mid_bios.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c > index a833568..cf4e605 100644 > --- a/drivers/gpu/drm/gma500/mid_bios.c > +++ b/drivers/gpu/drm/gma500/mid_bios.c > @@ -242,7 +242,7 @@ static int mid_get_vbt_data_r10(struct drm_psb_private *dev_priv, u32 addr) > gct_virtual = ioremap(addr + sizeof(vbt), > sizeof(*gct) * vbt.panel_count); > if (!gct_virtual) > - goto out; > + goto free_gct; > memcpy_fromio(gct, gct_virtual, sizeof(*gct)); > iounmap(gct_virtual); > > @@ -270,7 +270,7 @@ static int mid_get_vbt_data_r10(struct drm_psb_private *dev_priv, u32 addr) > dp_ti->vsync_pulse_width_lo = ti->vsync_pulse_width_lo; > > ret = 0; > -out: > + free_gct: > kfree(gct); > return ret; > } -- Jani Nikula, Intel Open Source Technology Center