From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbcF3OwK (ORCPT ); Thu, 30 Jun 2016 10:52:10 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:28002 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbcF3OwI (ORCPT ); Thu, 30 Jun 2016 10:52:08 -0400 Date: Thu, 30 Jun 2016 23:52:00 +0900 Message-ID: <87y45md90v.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Arnd Bergmann Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751 In-Reply-To: <4273068.i3RgB4Ufiy@wuerfel> References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-13-git-send-email-ysato@users.sourceforge.jp> <4273068.i3RgB4Ufiy@wuerfel> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jun 2016 23:57:50 +0900, Arnd Bergmann wrote: > > On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote: > > + interrupt-map = <0x0000 0 1 &cpldintc 0 0>, > > + 0x0800 0 1 &cpldintc 1 0>, > > + 0x1000 0 1 &cpldintc 2 0>, > > + 0x1800 0 1 &cpldintc 3 0>, > > + 0x1800 0 2 &cpldintc 0 0>; > > I just noticed the typo: you have more closing '>' than opening '<' > here, so this is not valid syntax. Oh. It too old files. I mistake commit. > > + > > +static __refdata struct platform_driver sh7751_pci_driver = { > > + .driver = { > > + .name = "sh7751-pci", > > + .of_match_table = sh7751_pci_of_match, > > + }, > > + .probe = sh7751_pci_probe, > > +}; > > +builtin_platform_driver(sh7751_pci_driver); > > I think you need to add '.suppress_bind_attrs = true' to prevent > the device to be unbound and rebound through sysfs, otherwise > the __init annotation on the probe function is wrong. Yes. This target hot add don't use. It flag required. > Everything else looks fine to me now. OK. Thanks. > Arnd > -- Yoshinori Sato