linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 1/2] perf tools: Compare dso's also when comparing symbols
Date: Tue, 15 Oct 2013 16:12:38 +0900	[thread overview]
Message-ID: <87y55v9fdl.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131015060829.GA4529@gmail.com> (Ingo Molnar's message of "Tue, 15 Oct 2013 08:08:29 +0200")

On Tue, 15 Oct 2013 08:08:29 +0200, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@kernel.org> wrote:
>
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Linus reported that sometimes 'perf report -s symbol' exits without any 
>> message on TUI.  David and Jiri found that it's because it failed to add 
>> a hist entry due to an invalid symbol length.
>
> Btw., 'exit without any messages' is something that should be fixed 
> separately as well I suspect.

Sure.  I believe acme is gonna work on it. :)

>
>>  static int64_t
>>  sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
>>  {
>> +	int64_t ret;
>> +
>
> Btw., this file should go back to u64/s64 like the kernel and most of perf 
> does. (A few int64_t uses slipped into other places as well, I suspect 
> they should be fixed.)

Okay, will send a separate patch for the fix.

Thanks,
Namhyung

  reply	other threads:[~2013-10-15  7:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  2:01 Namhyung Kim
2013-10-15  2:01 ` [RFC/PATCH 2/2] perf tools: Sort dso using pointers Namhyung Kim
2013-10-15  6:08 ` [PATCH 1/2] perf tools: Compare dso's also when comparing symbols Ingo Molnar
2013-10-15  7:12   ` Namhyung Kim [this message]
2013-10-23  7:54 ` [tip:perf/core] perf tools: Compare dso' s " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y55v9fdl.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --subject='Re: [PATCH 1/2] perf tools: Compare dso'\''s also when comparing symbols' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).