linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: richjunk@pacbell.net
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Johan Hovold <jhovold@gmail.com>
Subject: Re: [PATCH usb-linus] USB: keyspan: fix typo causing GPF on open
Date: Sun, 11 Nov 2012 11:22:55 +0100	[thread overview]
Message-ID: <87y5i8xwu8.fsf@nemi.mork.no> (raw)
In-Reply-To: <509EFDA3.4060900@pacbell.net> (Richard's message of "Sat, 10 Nov 2012 17:21:39 -0800")

Richard <richjunk@pacbell.net> writes:

> Bjørn:
>
> I patched keyspan.c using your below supplied diff in 3.6.6 (I'm not
> using git.)  The patch WORKS for me.  (I tested using minicom and the
> two programs that usually access the Keyspan serial device.)

Thanks for testing.  Good to know that this really was the problem you
were facing.

As you might have guessed, neither Johan nor I have the hardware to test
this driver. So your bug report and testing is extremely valuable.

> Thank you for the quick fix.

And thank you for an excellent bug report and quick testing.  The fact
that you could describe exactly which stable releases this appeared in
narrowed it down to just a single commit. And describing exactly what
happened narrowed it down to just a few possible places within that
commit.  This was the main reason the bug could be fixed this fast.

> Will this show up in 3.6.7?

That's for Greg to answer.  But don't be surprised if this came in too
late for 3.6.7.  All fixes for stable has to go through mainline first.



Bjørn

      reply	other threads:[~2012-11-11 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 19:38 kernel 3.6.5 and 3.6.6 GPF when use CONFIG_USB_SERIAL_KEYSPAN_USA49W Richard
2012-11-10  9:13 ` [PATCH usb-linus] USB: keyspan: fix typo causing GPF on open Bjørn Mork
2012-11-10 13:43   ` Johan Hovold
2012-11-11  1:21   ` Richard
2012-11-11 10:22     ` Bjørn Mork [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5i8xwu8.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhovold@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=richjunk@pacbell.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).