From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03291C43334 for ; Fri, 22 Jul 2022 13:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234948AbiGVNdC (ORCPT ); Fri, 22 Jul 2022 09:33:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbiGVNdB (ORCPT ); Fri, 22 Jul 2022 09:33:01 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C760695C3E; Fri, 22 Jul 2022 06:33:00 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 1226337B; Fri, 22 Jul 2022 13:33:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 1226337B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1658496780; bh=Gf5V+dDS778WCgJ/togXFN0/pG3fOa3s68V7PZ2pIPw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RO5yIM8BxfsxQCOD0hUS2p0Lsb7VUMsfoIchDID5s5uOCeDhnYf3/2HNtqzSYlcIW nrNZIfpDMwRNRK755WGJtpQqeB/dT/sgiMYWJ/qtoJKKn2s/uP9y9HKdo+EgChAtno c89hCjRi5ob0Ld+csJBqISv1AqAqgbuneXsrj+UDNkWSBVpqdwYPJZQ4N8zv4p2567 cMSvdGcLStjB71Avu2pxt+erN616fL3+xJeqSjGP8Gy7LfS6ZgiHGEo0rMqeICeBBb tbWmGfewvXeywFsjYhX+OOedw1nlf20AZWlYSQktnxic/u8HFglWXL6zcuWZS/KD7t AIlA2H6HqrB3w== From: Jonathan Corbet To: Yuji Ishikawa , Rob Herring , Hans Verkuil , Nobuhiro Iwamatsu , Sumit Semwal , Christian =?utf-8?Q?K=C3=B6nig?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, yuji2.ishikawa@toshiba.co.jp Subject: Re: [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver. In-Reply-To: <20220722082858.17880-6-yuji2.ishikawa@toshiba.co.jp> References: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp> <20220722082858.17880-6-yuji2.ishikawa@toshiba.co.jp> Date: Fri, 22 Jul 2022 07:32:58 -0600 Message-ID: <87zgh1jmr9.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yuji Ishikawa writes: No changelog? > Signed-off-by: Yuji Ishikawa > --- > v1 -> v2: > - newly added documents > --- > Documentation/driver-api/visconti/common.rst | 115 ++++++ > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++++++++ > 2 files changed, 509 insertions(+) > create mode 100644 Documentation/driver-api/visconti/common.rst > create mode 100644 Documentation/driver-api/visconti/dnn.rst Two overall comments: - You've added new RST files without adding them to index.rst; that will keep them from being part of the kernel docs build and will add new warnings. - Please avoid the use of flat-table and just use regular RST ascii-art tables. Otherwise the result is nearly unreadable in the plain-test format. Thanks, jon