From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68C9C63793 for ; Thu, 22 Jul 2021 15:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95EA56135B for ; Thu, 22 Jul 2021 15:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232643AbhGVOkr (ORCPT ); Thu, 22 Jul 2021 10:40:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:60894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232475AbhGVOgr (ORCPT ); Thu, 22 Jul 2021 10:36:47 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E2AE61029; Thu, 22 Jul 2021 15:17:13 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m6aRj-000I6k-69; Thu, 22 Jul 2021 16:17:11 +0100 Date: Thu, 22 Jul 2021 16:17:10 +0100 Message-ID: <87zgue1iq1.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: LKML , Alex Williamson , "Raj, Ashok" , "David S. Miller" , Bjorn Helgaas , linux-pci@vger.kernel.org, Kevin Tian , Ingo Molnar , x86@kernel.org Subject: Re: [patch 0/8] PCI/MSI, x86: Cure a couple of inconsistencies In-Reply-To: <20210721191126.274946280@linutronix.de> References: <20210721191126.274946280@linutronix.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, ashok.raj@intel.com, davem@davemloft.net, bhelgaas@google.com, linux-pci@vger.kernel.org, kevin.tian@intel.com, mingo@kernel.org, x86@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jul 2021 20:11:26 +0100, Thomas Gleixner wrote: > > A recent discussion about the PCI/MSI management for virtio unearthed a > violation of the MSI-X specification vs. writing the MSI-X message: under > certain circumstances the entry is written without being masked. > > While looking at that and the related violation of the x86 non-remapped > interrupt affinity mechanism a few other issues were discovered by > inspection. > > The following series addresses these. > > Note this does not fix the virtio issue, but while staring at the above > problems I came up with a plan to address this. I'm still trying to > convince myself that I can get away without sprinkling locking all over the > place, so don't hold your breath that this will materialize tomorrow. > > The series is also available from git: > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git irq/msi > > Thanks, > > tglx > --- > arch/x86/kernel/apic/io_apic.c | 6 +- > arch/x86/kernel/apic/msi.c | 11 +++- > arch/x86/kernel/hpet.c | 2 > drivers/pci/msi.c | 98 +++++++++++++++++++++++++++-------------- > include/linux/irq.h | 2 > kernel/irq/chip.c | 5 +- > 6 files changed, 85 insertions(+), 39 deletions(-) The couple of nits I mentioned notwithstanding, this looks good to me. I've taken it for a short ride on an arm64 box (both bare metal and guests), and nothing exploded. Must be good! Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.