From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E61C433ED for ; Fri, 16 Apr 2021 13:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15ABB611AB for ; Fri, 16 Apr 2021 13:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235741AbhDPNlh (ORCPT ); Fri, 16 Apr 2021 09:41:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:46456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233606AbhDPNlg (ORCPT ); Fri, 16 Apr 2021 09:41:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1FCA6113B; Fri, 16 Apr 2021 13:41:11 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lXOib-007reT-Kh; Fri, 16 Apr 2021 14:41:09 +0100 Date: Fri, 16 Apr 2021 14:41:08 +0100 Message-ID: <87zgxys5xn.wl-maz@kernel.org> From: Marc Zyngier To: Robert Hancock Cc: tglx@linutronix.de, michal.simek@xilinx.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip/xilinx: Expose Kconfig option In-Reply-To: <20210415233250.4071772-1-robert.hancock@calian.com> References: <20210415233250.4071772-1-robert.hancock@calian.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: robert.hancock@calian.com, tglx@linutronix.de, michal.simek@xilinx.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Apr 2021 00:32:50 +0100, Robert Hancock wrote: > > Previously the XILINX_INTC config option was hidden and only > auto-selected on the MicroBlaze platform. However, this IP can also be > used on other platforms. Allow this option to be user-enabled. > > Signed-off-by: Robert Hancock I don't think this is a good idea. In general, people have no idea which interrupt controller they need to select. So you either end-up with a missing interrupt controller, or a bunch you really don't need. This is essentially a platform constraint, and this should directly be selected by the platform if you have this IP in your system. Thanks, M. -- Without deviation from the norm, progress is not possible.