From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB235C433E0 for ; Mon, 22 Mar 2021 11:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C26D061991 for ; Mon, 22 Mar 2021 11:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbhCVLUY (ORCPT ); Mon, 22 Mar 2021 07:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhCVLUK (ORCPT ); Mon, 22 Mar 2021 07:20:10 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7199FC061756 for ; Mon, 22 Mar 2021 04:20:09 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id w37so20625558lfu.13 for ; Mon, 22 Mar 2021 04:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waldekranz-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=qI7goXjjGFeqHfifATUNUhUdn1BuomusuiEhucOhm2g=; b=qQ1l8VYivqDkzxJB3JRdAFBjzLic10uHyL/uUUFstkQ9ud2jIBdOHMURo/N30v5p3G 4tsmcJFoI/2feqcwCikMhc9nmWqbs2V4Z5ByQbXSA4FGxdoNaKFoQxjoD4/BABefTXol Ju7lDesqUN9YEc7J0ZMXMN5fTvMmao+wJHvnJI1HEnUM+IRC7Wliy0/O83jTFmrNtGD9 h1B2Ful/MXkj8CqbzbGHcwsYi1TE1ZzlwbLZMEo7W06ki68s/V7b7iGRzu+8wPoRndPm TPa9Mdki+FOnedg6gNAVgHDATWIPwg1nktRMUbuOsKzgFVx3PYvwV0OZXCPV72Hl/sXk 0kuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=qI7goXjjGFeqHfifATUNUhUdn1BuomusuiEhucOhm2g=; b=HLQtT52FvoSAk87BOcOPTgQg4C+xCuEdfNW+Rw8FdVYBXVZULW32D5ECJsGfE18ZkU QLDxNum1f6C20oJP8faLx8gLvehpoyC9OQemo9T3kmmQ+6Jvpx8+GfrRiKWKvI7NOp4S jX1wlZKtlGIoqIXpuZN01+zNYDIghPVX7oAy7XbZM8y8Pq7csQdq8lXmyWSyjPtxyh9W 4vjJzom1GTIkBF4mxS3hsRFSUiKELGBRB7ZGNlP0fJBYa2snWf1zHOyWplNBcAu4t9yG 4E7n0XhCh9s8rPpQlDgaCzIvVUp4yWiq38Gp6uIUMRzs83KTbcCO+7Ah7hLZ/hhdcyMm 3P1w== X-Gm-Message-State: AOAM533PURtl5/5ZE3JNsJDFp/si2DePcNXfDxXUIGXSMTWid/5BFYkb Frr4s8Vz+N8zLCDYsgEQ/b/0Ew== X-Google-Smtp-Source: ABdhPJwA6JgdgFdF9FQMAXM2grOYAiw4AJkNivEq2/o2XmDjXIwu0iCVDbg6X5C8BWVB/ftnv++C+Q== X-Received: by 2002:a19:4116:: with SMTP id o22mr8893165lfa.272.1616412007906; Mon, 22 Mar 2021 04:20:07 -0700 (PDT) Received: from wkz-x280 (static-193-12-47-89.cust.tele2.se. [193.12.47.89]) by smtp.gmail.com with ESMTPSA id e15sm1539506lfs.83.2021.03.22.04.20.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 04:20:07 -0700 (PDT) From: Tobias Waldekranz To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Vignesh Raghavendra , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org, Vladimir Oltean Subject: Re: [RFC PATCH v2 net-next 07/16] net: dsa: sync ageing time when joining the bridge In-Reply-To: <20210318231829.3892920-8-olteanv@gmail.com> References: <20210318231829.3892920-1-olteanv@gmail.com> <20210318231829.3892920-8-olteanv@gmail.com> Date: Mon, 22 Mar 2021 12:20:06 +0100 Message-ID: <87zgyvmo49.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 19, 2021 at 01:18, Vladimir Oltean wrote: > From: Vladimir Oltean > > The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: > > sysfs/ioctl/netlink > -> br_set_ageing_time > -> __set_ageing_time > > therefore not at bridge port creation time, so: > (a) drivers had to hardcode the initial value for the address ageing time, > because they didn't get any notification > (b) that hardcoded value can be out of sync, if the user changes the > ageing time before enslaving the port to the bridge > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Tobias Waldekranz