From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A86FC4332B for ; Mon, 15 Mar 2021 20:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 138EC64E90 for ; Mon, 15 Mar 2021 20:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232651AbhCOUX6 (ORCPT ); Mon, 15 Mar 2021 16:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230510AbhCOUXk (ORCPT ); Mon, 15 Mar 2021 16:23:40 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A43C06174A; Mon, 15 Mar 2021 13:23:40 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id A28032C4; Mon, 15 Mar 2021 20:23:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net A28032C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1615839819; bh=8ws2nYd8idINmMTSo0rM0NTC8mXgmRjt0C2UAnbrNkA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B7hRlYWS13GXFid/2XM2hWVEFL+frnqjOj0zmtPSITcFiC5OWcwKXugb97AGiS2ck wE4geBC0/UE9Z0wQEFqIg3LRvQo7BCCLzTHNxtW5U369K12tYwPR6fGKtqFiwlKhql seg5M2Grzwh9uNrbfiGxpJp0pHMPMFs9gwdHJzxvZG0viGRhX6pbn+VApecS0FzROk bS7f/p4bVCYKGHdGKaLmXIhnYIeokr24MTnQmdGCOYEgyNEx8LabjXMpuewpzLc6D3 iEp5RcNvyuyGD4jT8zESAZR5VO8jf014LR89q8fEz0BElEbSuyfwJQScQphWh0TCwS 32W/uzLdjLGXQ== From: Jonathan Corbet To: Gao Xiang , linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Gao Xiang , Matthias Kaehlcke , Greg Kroah-Hartman , Zefan Li Subject: Re: [PATCH] Documentation: sysrq: update description about sysrq crash In-Reply-To: <20210309191550.3955601-1-hsiangkao@redhat.com> References: <20210309191550.3955601-1-hsiangkao@redhat.com> Date: Mon, 15 Mar 2021 14:23:39 -0600 Message-ID: <87zgz4yxmc.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gao Xiang writes: > After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"), > a crash was not generated by dereferencing a NULL pointer anymore. > > Let's update documentation as well to make it less misleading. > > Cc: Matthias Kaehlcke > Cc: Greg Kroah-Hartman > Cc: Jonathan Corbet > Cc: Zefan Li > Signed-off-by: Gao Xiang > --- > Documentation/admin-guide/sysrq.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst > index 67dfa4c29093..60ce5f5ebab6 100644 > --- a/Documentation/admin-guide/sysrq.rst > +++ b/Documentation/admin-guide/sysrq.rst > @@ -90,8 +90,8 @@ Command Function > ``b`` Will immediately reboot the system without syncing or unmounting > your disks. > > -``c`` Will perform a system crash by a NULL pointer dereference. > - A crashdump will be taken if configured. > +``c`` Will perform a system crash and a crashdump will be taken > + if configured. Makes sense. Applied, thanks. jon