From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A68EC433E7 for ; Fri, 16 Oct 2020 23:10:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D73D22201 for ; Fri, 16 Oct 2020 23:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="RNzrE8wz"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="3cowJjfP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409650AbgJPXJ7 (ORCPT ); Fri, 16 Oct 2020 19:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408364AbgJPXJs (ORCPT ); Fri, 16 Oct 2020 19:09:48 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0150C0613D5 for ; Fri, 16 Oct 2020 16:09:47 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602889786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cA4HbeG5F1/kkAuX6BXrrQBRE+JeZsIFauduiNTWrGw=; b=RNzrE8wzQHrE2DB0dNM9+GZsQsAQd6BWjIQLZ5fw/O/ynEcg06oJuUpqNvEfKeuy72r2uf mCP0D+MJF4rfVyv5RHklWgQ7zaFAqpIZi56QXlE3zN/ggIamWQ6UKNbW1yWbj9glyeA3DX L2/ltrDE7ywr9n9wfJ90qE2+vK3F2veVKc8H/oN784yACwrwq6uclWJ2lUH/yvFytsQKCB r6UnUiPZ2lKXgyVqAK5EZJ9jahoGudSjZX5UHicTbAwS9AL16ssXZXFNcZrjh2A+TFetsG y5gY9X06/lreOS0rtowN0ogpYhxMqa0TVtqa8jhAlyzqrlU3V6f8R92lcRzqWg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602889786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cA4HbeG5F1/kkAuX6BXrrQBRE+JeZsIFauduiNTWrGw=; b=3cowJjfPa/UmRjdjY/eQshugOr19LwaW4JzZ7BHeIMLSuXN1jCqjqI2rBjNqpWtzlTYns+ AOTOP8FELsfyoVCw== To: Jens Axboe Cc: "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] task_work: cleanup notification modes In-Reply-To: References: <93292d5b-9124-d252-c81f-1f2cfbd60e7b@kernel.dk> <87tuutalre.fsf@nanos.tec.linutronix.de> Date: Sat, 17 Oct 2020 01:09:46 +0200 Message-ID: <87zh4lix8l.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 16 2020 at 16:39, Jens Axboe wrote: > On 10/16/20 3:44 PM, Thomas Gleixner wrote: >>> - * @notify: send the notification if true >>> + * @notify: send chosen notification, if any >> >> Is that really all you found to be wrong in that comment? > > There really is nothing wrong, but it's not very descriptive (wasn't > before either). * This is like the signal handler which runs in kernel mode, but it doesn't * try to wake up the @task. If find a lot of wrongs in that sentence in context of TWA_SIGNAL. Agreed, it was hard to understand before that, but with TWA_SIGNAL it does not make sense at all. Thanks, tglx