From: Felipe Balbi <balbi@kernel.org>
To: "Peter Chen" <peter.chen@nxp.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP
Date: Wed, 01 Jul 2020 09:53:54 +0300 [thread overview]
Message-ID: <87zh8j7mkd.fsf@kernel.org> (raw)
In-Reply-To: <AM7PR04MB715735B54F24293ABF7B37908B8C0@AM7PR04MB7157.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
Peter Chen <peter.chen@nxp.com> writes:
>
>> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned
>> intf, unsigned alt)
>> > > /* we know alt == 0, so this is an activation or a reset */
>> > >
>> > > if (intf == acm->ctrl_id) {
>> > > - dev_vdbg(&cdev->gadget->dev,
>> > > - "reset acm control interface %d\n", intf);
>> > > - usb_ep_disable(acm->notify);
>> > > + if (acm->notify->enabled) {
>> > > + dev_vdbg(&cdev->gadget->dev,
>> > > + "reset acm control interface %d\n", intf);
>> > > + usb_ep_disable(acm->notify);
>> > > + }
>> >
>> > But it does not fix any issues, the usb_ep_disable checks 'enabled' flag.
>>
>> It generates spurious trace events if you enable them.
>>
>
> You mean the trace events from core.c? If it is, we could try to improve it
> and indicate it is already enabled or disabled.
I agree :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-07-01 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 18:30 [PATCH] usb: gadget: f_acm: don't disable disabled EP Michał Mirosław
2020-05-29 8:10 ` Peter Chen
2020-05-29 13:55 ` Michał Mirosław
2020-05-30 1:03 ` Peter Chen
2020-05-30 17:15 ` Michał Mirosław
2020-06-01 3:53 ` Peter Chen
2020-07-01 6:54 ` Felipe Balbi
2020-07-01 6:53 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh8j7mkd.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).