From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B29EC3F2CE for ; Fri, 6 Mar 2020 03:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F4C320801 for ; Fri, 6 Mar 2020 03:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgCFD35 (ORCPT ); Thu, 5 Mar 2020 22:29:57 -0500 Received: from mga14.intel.com ([192.55.52.115]:2171 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgCFD34 (ORCPT ); Thu, 5 Mar 2020 22:29:56 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2020 19:29:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,520,1574150400"; d="scan'208";a="439984539" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.23]) by fmsmga005.fm.intel.com with ESMTP; 05 Mar 2020 19:29:54 -0800 From: "Huang\, Ying" To: "Rafael J. Wysocki" Cc: Rong Chen , "Rafael J. Wysocki" , LKML , ACPI Devel Maling List , "open list\:ACPI COMPONENT ARCHITECTURE \(ACPICA\)" , Linux PM , , Andi Kleen Subject: Re: [LKP] Re: [cpufreq] 909c0e9cc1: fwq.fwq.med 210.0% improvement References: <20200305013509.GF5972@shao2-debian> <951b0986-bb35-d9a5-1639-0a8cdb3dcd04@intel.com> Date: Fri, 06 Mar 2020 11:29:53 +0800 In-Reply-To: (Rafael J. Wysocki's message of "Thu, 5 Mar 2020 10:05:48 +0100") Message-ID: <87zhcuyxce.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rafael, "Rafael J. Wysocki" writes: > On Thu, Mar 5, 2020 at 9:18 AM Rong Chen wrote: >> >> >> >> On 3/5/20 3:50 PM, Rafael J. Wysocki wrote: >> > On 3/5/2020 2:35 AM, kernel test robot wrote: >> >> Greeting, >> >> >> >> FYI, we noticed a 210.0% improvement of fwq.fwq.med due to commit: >> > >> > Well, that sounds impressive. :-) >> > >> > >> >> >> >> commit: 909c0e9cc11ba39fa5a660583b25c2431cf54deb ("cpufreq: >> >> intel_pstate: Use passive mode by default without HWP") >> >> https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git >> >> intel_pstate-passive >> >> >> >> in testcase: fwq >> >> on test machine: 16 threads Intel(R) Xeon(R) CPU D-1541 @ 2.10GHz >> >> with 48G memory >> >> with following parameters: >> >> >> >> nr_task: 100% >> >> samples: 100000ss >> >> iterations: 18x >> >> cpufreq_governor: powersave >> > >> > The governor should be schedutil, though, unless it is explicitly set >> > to powersave in the test environment. >> > >> > Is that the case? >> > >> > >> >> Hi Rafael, >> >> Yes, we set to powersave for this test. > > I wonder why this is done? Is there any particular technical reason > for doing that? fwq is a noise benchmark to measure the hardware and software noise level. More information could be found in the following document. https://asc.llnl.gov/sequoia/benchmarks/FTQ_summary_v1.1.pdf In 0day, to measure the noise introduced by power management, we will run fwq with the performance and powersave governors. Do you think this is reasonable? Or we should use some other governors? Best Regards, Huang, Ying